Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing FocusChangeEvent #81

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Add missing FocusChangeEvent #81

merged 1 commit into from
Mar 25, 2022

Conversation

scolej
Copy link
Contributor

@scolej scolej commented Mar 21, 2022

Hi, this PR adds the FocusChangeEvent which seems to be missing.

Copy link
Member

@slotThe slotThe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slotThe
Copy link
Member

slotThe commented Mar 25, 2022

@geekosaur @liskin what do you people think?

@geekosaur
Copy link
Contributor

I think we may be missing a few others as well, and had always wondered why. I'm fine with it.

@slotThe slotThe merged commit 0a7e83b into xmonad:master Mar 25, 2022
@slotThe
Copy link
Member

slotThe commented Mar 25, 2022

Cool, thanks!

@scolej
Copy link
Contributor Author

scolej commented Mar 26, 2022

Thank you both. I'll keep an eye out for other missing items...

@liskin
Copy link
Member

liskin commented Mar 26, 2022

@scolej Shall we cut a release (we'll still need a changelog entry for this PR) now or do you intend to add more missing stuff soon?

@scolej
Copy link
Contributor Author

scolej commented Apr 6, 2022

Hoping to add some more stuff:

  • createnotify event
  • some missing constants in Types.hsc

@scolej scolej mentioned this pull request Jun 4, 2022
@liskin
Copy link
Member

liskin commented Jun 18, 2022

With #82 now merged, time to do a release? :-)
(Still needs an entry in CHANGES.md)

liskin added a commit that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants