X.L.TrackFloating: Clean up and simplify #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop Eq constraint that isn't needed. Drop the redundant Maybe from findZ return type. Breaks symmetry but makes it easier to use (join no longer needed).
X.L.TrackFloating is more or less the same as X.L.StateFull's FocusTracking, so it's no surprise the same helpers can be used...
It was added in 81d3389 in an attempt to fix focus handling after closing a floating window, but shortly after made redundant in a551d13 when we noticed it causes more harm than good. Unfortunately it wasn't fully reverted, making the code more complex than necessary. Drop the remaining bits. Now it's almost obvious that the only difference between this and X.L.StateFull.FocusTracking is the isF condition. BTW the original issue 81d3389 was trying to fix can be fixed by using X.H.RefocusLast, from the author of X.L.StateFull.FocusTracking. :-)
It seems the logic used in X.L.StateFull's FocusTracking should cover all use cases here. Let's try it for a while. :-)
3 tasks
3 tasks
LSLeary
added a commit
to LSLeary/xmonad-contrib
that referenced
this pull request
Dec 5, 2022
X.L.StateFull's `FocusTracking` and the eponymous `TrackFloating` were redundant, hence the former was slated for deprecation. However, the latter and its host module are somewhat poorly named; the layout modifier has little relation to floats. As such, it's renamed and rehosted, becoming the eponymous `FocusTracking`. The redundant offerings in the original modules are redefined in terms of the new module where possible, and deprecated. See: xmonad#418; comments on xmonad#253, xmonad#783.
3 tasks
LSLeary
added a commit
to LSLeary/xmonad-contrib
that referenced
this pull request
Feb 12, 2023
X.L.StateFull's `FocusTracking` and the eponymous `TrackFloating` were redundant, hence the former was slated for deprecation. However, the latter and its host module are somewhat poorly named; the layout modifier has little relation to floats. As such, it's renamed and rehosted, becoming the eponymous `FocusTracking`. The redundant offerings in the original modules are redefined in terms of the new module where possible, and deprecated. See: xmonad#418; comments on xmonad#253, xmonad#783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#253 added a similar module using a somewhat simpler implementation. Borrow some ideas and share some code, so that we can possibly deprecate one in favor of the other.
Checklist
I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the
CHANGES.mdfilen/a I updated the
XMonad.Doc.Extendingfile (if appropriate)