Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move windows builds from AppVeyor to CircleCI #2090

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Move windows builds from AppVeyor to CircleCI #2090

merged 1 commit into from
Jan 25, 2021

Conversation

evgenykochetkov
Copy link
Contributor

No description provided.

@evgenykochetkov evgenykochetkov self-assigned this Jan 25, 2021
knopki
knopki requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@knopki knopki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Windows host works unexpectedly fast.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
nkrkv
nkrkv approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Shouldn’t it be targeted toward master instead of 0.37.x?

knopki
knopki approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@knopki knopki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evgenykochetkov evgenykochetkov merged commit 2cd4f91 into 0.37.x Jan 25, 2021
@evgenykochetkov evgenykochetkov deleted the circleci-windows branch January 25, 2021 15:58
This was referenced Jan 25, 2021
Merged
Merged
@brusherru brusherru mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@knopki knopki knopki approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evgenykochetkov @nkrkv @knopki @brusherru