Pin node versions in CircleCI runners. #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopki
approved these changes
Jan 27, 2021
brusherru
approved these changes
Jan 27, 2021
evgenykochetkov
force-pushed
the
pin-node-version
branch
from
9cc1f56
to
c894f55
Compare
…`.nvmrc` contain the exact same version of node.js that ships with the current Electron version we're using
evgenykochetkov
force-pushed
the
pin-node-version
branch
from
c894f55
to
a3180f9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(finishing what was started while discussing #2090)
Now the exact version of node that is shipped with electron is specified in
.nvmrcandenginesfield ofpackage.json.In windows and macOS runners, that version is installed with nvm.
For linux runners, Docker image is updated to include the required version.