Support min, mins abbreviations for minutes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although coverage fails, I believe the new functionality to be sufficiently tested. (y) |
xolox
added a commit
that referenced
this pull request
May 4, 2017
In this merge commit I'm making two changes compared to #14: 1. I've documented the supported time units and abbreviations. 2. I've changed the body of parse_timespan() to remove the three list allocations per iteration. Before the pull request there was one tuple allocation per iteration. Now there are two equality comparisons and a `contains' test (in) per iteration. The slightly less readable code seems like a small sacrifice in this case. Maybe I've programmed too much C? :-)
xolox
added a commit
that referenced
this pull request
May 4, 2017
I've decided to bump the major version number after merging pull request #14 because the `humanfriendly.time_units' data structure was changed. Even though this module scope variable isn't included in the online documentation, nothing stops users from importing it anyway, so this change is technically backwards incompatible. Besides, version numbers are cheap. In fact, they are infinite! :-)
|
Hi Brandon and thanks for the pull request! This is now merged and released as humanfriendly 3.0. |
|
Bravo! Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I've been very happy with the
parse_timespanfunctionality of humanfriendly. The only issue I've had is that sometimes I'd like to say "3 min" or "3 mins" for minutes.Solution
I've changed
time_unitsto allow for multiple abbreviations per time unit. I also changedparse_timespanto look through all abbreviations when parsing times. Finally, I added "min" and "mins" as abbreviations for minutes.Outcome
Parsing "3 min" and "3 mins" is now supported!