Added format_length and parse_length functions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xolox
added a commit
that referenced
this pull request
Jul 27, 2015
|
Hi Jason and thanks for your contribution! This is one of the better pull requests I've received on my projects so far: After checking your changes I merged them, bumped the version number and made a release, that was all. Usually I'm the one adding tests, writing docs or extending the command line :-). |
|
No problem! I'd been looking for a module which did this, found yours, but it didn't support the exact option I was looking for, so I thought it'd make more sense to add this in to humanfriendly instead of coding something separately, so that others could benefit too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two functions for dealing with SI units of length. Wrote new unit tests, which all pass on local repo.