Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: DataFrame Where OP Support #756

Closed
wants to merge 21 commits into from
Closed

FEAT: DataFrame Where OP Support #756

wants to merge 21 commits into from

Conversation

fengsxy
Copy link
Contributor

@fengsxy fengsxy commented Nov 14, 2023

What do these changes do?

make the code support for Where Operation

@XprobeBot XprobeBot added this to the v0.7.1 milestone Nov 14, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.85714% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (e4a996f) to head (efc498c).
Report is 12 commits behind head on main.

❗ Current head efc498c differs from pull request most recent head 672f49e

Please upload reports for the commit 672f49e to get more accurate results.

Files Patch % Lines
python/xorbits/_mars/dataframe/base/where.py 82.52% 10 Missing and 8 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   93.55%   93.58%   +0.02%     
==========================================
  Files        1059     1060       +1     
  Lines       79781    79886     +105     
  Branches    16504    16522      +18     
==========================================
+ Hits        74640    74761     +121     
+ Misses       3461     3439      -22     
- Partials     1680     1686       +6
Flag Coverage Δ
unittests 93.47% <82.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fengsxy and others added 4 commits November 13, 2023 22:29
@fengsxy
update test_base
e29be6d
@fengsxy
ut supply
e31a51b
@fengsxy
ut supply
efc498c
@traderbxy @ChengjieLi28 @luweizheng
BUG: Fix pd.read_csv cannot read pathlib.Path (xorbitsai#757)
1964357 
Co-authored-by: ChengjieLi <chengjieli23@outlook.com>
Co-authored-by: Lu Weizheng <luweizheng36@hotmail.com>
@XprobeBot XprobeBot modified the milestones: v0.7.1, v0.7.2 Nov 21, 2023
JiaYaobo and others added 5 commits November 22, 2023 15:18
@JiaYaobo
ENH: Modify JAX fusion optimization (xorbitsai#755)
eb07b4f
@dependabot @mergify
Bump @babel/traverse from 7.22.8 to 7.23.2 in /python/xorbits/web/ui (x…
de8c809 
…orbitsai#749)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@luweizheng @codingl2k1
CHORE: drop CI support for python 3.8 (xorbitsai#765)
8a7f7d1 
Co-authored-by: codingl2k1 <codingl2k1@outlook.com>
@luweizheng @codingl2k1
DOC: add citation on README.md (xorbitsai#766)
8cdaa8f 
Co-authored-by: codingl2k1 <codingl2k1@outlook.com>
@Hank0626
BUG: fix read s3 parquet (xorbitsai#764)
b1f1107
@XprobeBot XprobeBot modified the milestones: v0.7.2, v0.7.3 Jan 5, 2024
luweizheng and others added 11 commits June 3, 2024 14:22
@luweizheng @codingl2k1
ENH: fix test CI dependency of hadoop, lightgbm and web ui (xorbitsai…
72b2035 
…#772)

Co-authored-by: codingl2k1 <codingl2k1@outlook.com>
@luweizheng @codingl2k1
@Dawnfz-Lenfeng @mergify
TST: compatible libs with pandas 1.5.3 (xorbitsai#775)
374e6f0 
Co-authored-by: codingl2k1 <codingl2k1@outlook.com>
Co-authored-by: u2022201752 via LDAP <2912706234@qq.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@luweizheng
BUG: fix compatibility issue of df.sort_index() and df.groupby(sort=T…
79c3bc8 
…rue) (xorbitsai#776)
@Dawnfz-Lenfeng
ENH: Remove sum_over_features parameter from manhattan_distances …
f2fa7cf 
…with sklearn > 1.4 (xorbitsai#779)
@luweizheng @mergify
CHORE: limit numpy<2.0 as xorbits is not fully prepared for it (xorbi…
1242066 
…tsai#782)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@luweizheng @mergify
BUG: fix CI of pypi & dockerhub (xorbitsai#777)
3986478 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@fengsxy @luweizheng
new
691de59
@fengsxy @luweizheng
update test_base
a04791f
@fengsxy @luweizheng
ut supply
edc8dbd
@fengsxy @luweizheng
ut supply
b07937f
@luweizheng
Merge branch 'new' of github.com:fengsxy/xorbits into HEAD
672f49e
@luweizheng luweizheng self-requested a review June 21, 2024 06:22
@Dawnfz-Lenfeng Dawnfz-Lenfeng mentioned this pull request Jun 27, 2024
Closed
2 tasks
@luweizheng
Copy link
Collaborator

We have already implemented df.where and df.mask in python/xorbits/_mars/dataframe/indexing/where.py.

@luweizheng luweizheng closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luweizheng luweizheng Awaiting requested review from luweizheng

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.7.3
Development

Successfully merging this pull request may close these issues.
7 participants
@fengsxy @luweizheng @XprobeBot @traderbxy @JiaYaobo @Hank0626 @Dawnfz-Lenfeng