Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate XP annotation syntax #284

Merged
merged 4 commits into from
Oct 19, 2021
Merged

Conversation

thekid
Copy link
Member

@thekid thekid commented Oct 18, 2021

The following code (which creates a parse error in PHP 8!) will throw deprecation warnings with PHP 7 when accessing annotations reflectively.

class DemoTest {

  #[@test]
  public function can_create_demo() {
    // ...
  }
}

Causes E_USER_DEPRECATED: "XP annotation syntax is deprecated in DemoTest, line 6"

Part 2 of xp-framework/rfc#336

@thekid
Copy link
Member Author

thekid commented Oct 18, 2021

Tests are currently failing for some weird and unreproducible reason, see #285

Temporary issue with Github actions, fixed now.

@thekid thekid merged commit 332b2a9 into xp-framework:main Oct 19, 2021
@thekid thekid deleted the rfc/336-deprecate-xp branch October 19, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant