-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGTERM signal #59
Comments
xqms
added a commit
that referenced
this issue
Oct 26, 2018
I agree, SIGTERM and SIGHUP should be handled gracefully as well. Could you check if #60 fits your requirements? |
Yes, it is exactly the patch I have tried locally.
Thank you.
Le ven. 26 oct. 2018 à 23:42, Max Schwarz <notifications@github.com> a
écrit :
… I agree, SIGTERM and SIGHUP should be handled gracefully as well. Could
you check if #60 <#60> fits your
requirements?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#59 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIb5YA0NPcjwgfmrSxLjHrdujVL-mQ2eks5uo4G5gaJpZM4X5w1P>
.
|
Merged #60. Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rosmon
already handlesSIGINT
signal here:rosmon/src/main.cpp
Line 389 in edf2742
But
roslaunch
also handlesSIGTERM
andSIGUP
signals as seen here:https://github.com/ros/ros_comm/blob/89ca9a7bf288b09d033a1ab6966ef8cfe39e1002/tools/roslaunch/src/roslaunch/pmon.py#L162
One use case I have is when a
rosmon
instance is launched within a QProcess. QProcess only providesSIGTERM
, via QProcess::termate() andSIGKILL
via QProcess::kill().As
SIGTERM
andSIGINT
are quite close in semantics according to this page, I think that it would be nice ifrosmon
also handlesSIGTERM
.What do you think about that?
The text was updated successfully, but these errors were encountered: