Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGTERM signal #59

Closed
romainreignier opened this issue Oct 25, 2018 · 3 comments
Closed

Handle SIGTERM signal #59

romainreignier opened this issue Oct 25, 2018 · 3 comments

Comments

@romainreignier
Copy link
Contributor

rosmon already handles SIGINT signal here:

signal(SIGINT, handleSIGINT);

But roslaunch also handles SIGTERM and SIGUP signals as seen here:

https://github.com/ros/ros_comm/blob/89ca9a7bf288b09d033a1ab6966ef8cfe39e1002/tools/roslaunch/src/roslaunch/pmon.py#L162

One use case I have is when a rosmon instance is launched within a QProcess. QProcess only provides SIGTERM, via QProcess::termate() and SIGKILL via QProcess::kill().

As SIGTERM and SIGINT are quite close in semantics according to this page, I think that it would be nice if rosmon also handles SIGTERM.

What do you think about that?

@xqms
Copy link
Owner

xqms commented Oct 26, 2018

I agree, SIGTERM and SIGHUP should be handled gracefully as well. Could you check if #60 fits your requirements?

@romainreignier
Copy link
Contributor Author

romainreignier commented Oct 26, 2018 via email

@xqms
Copy link
Owner

xqms commented Oct 27, 2018

Merged #60. Thanks for checking!

@xqms xqms closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants