Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of more than 62 nodes #93

Closed
matawed opened this issue Jul 22, 2019 · 8 comments
Closed

Support of more than 62 nodes #93

matawed opened this issue Jul 22, 2019 · 8 comments

Comments

@matawed
Copy link

matawed commented Jul 22, 2019

Unfortunately, if I start more than 62 nodes, then I don't have the possibility to control the nodes >62 in the command line interface as I can only refer to nodes 0..61 via a-z,A-Z,0-9.

Did you ever think of an command line interface for more than 62 nodes?

@xqms
Copy link
Owner

xqms commented Jul 24, 2019

I've been thinking about a search mode for a while now (like less/vi, triggered with '/'), which would reduce the list of nodes to a number that is manageable using the current shortcut system.

Do you have a better/different idea?

@matawed
Copy link
Author

matawed commented Jul 25, 2019

I like the idea with the search mode similar to vim.

@clungzta
Copy link

clungzta commented Oct 16, 2019

Search would be great! Another benefit of the search is less time and difficulty to perform actions on a node.

For example: as a new user, if I wish to perform an action to the move_base node, I instinctively type 'm', when in fact it is assigned node key 'a', then I have to look at the list and correct my entry.

@xqms
Copy link
Owner

xqms commented Oct 16, 2019

Since there is interest in this, let's try to brainstorm. What do you think about the following UI flow:

  1. User types '/' to initiate search
  2. User starts to type a regular expression / prefix (needs to be decided)
  3. rosmon displays only the matching nodes, but in the same UI as before.
  4. At any point, the user can press enter to "fix" the search and use the usual node keybindings (a-z) to access the search results.
  5. Another enter or escape exits the search mode.

The drawback that I see is that we change node keybindings, i.e. your move_base node would be accessible using 'g' in the normal mode, but then using 'a' if you search for move_base.

What do you think? Can you imagine a better alternative?

@xqms
Copy link
Owner

xqms commented Oct 16, 2019

Alternative (let's call this variant B):

  1. User types '/' to initiate search
  2. User starts to type a regular expression / prefix
  3. rosmon displays all matching nodes, with the first one "selected" (highlighted). Pressing tab selects the next node from the result list.
  4. The user can type further or select a node using enter. Pressing escape aborts the process.

I guess that's more in line with how other tools do it.

@clungzta
Copy link

Variant b sounds quite nice! 👍

@xqms xqms mentioned this issue Oct 16, 2019
@xqms
Copy link
Owner

xqms commented Oct 16, 2019

I implemented a draft solution in #97. Let's continue the discussion there. Beta-testers welcome!

@xqms
Copy link
Owner

xqms commented Oct 17, 2019

Fixed in #97.

@xqms xqms closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants