Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you want me to add an all-in-one GitHub action? #14

Closed
KTibow opened this issue Dec 19, 2020 · 4 comments · Fixed by #17
Closed

Do you want me to add an all-in-one GitHub action? #14

KTibow opened this issue Dec 19, 2020 · 4 comments · Fixed by #17
Labels
enhancement New feature or request

Comments

@KTibow
Copy link
Contributor

KTibow commented Dec 19, 2020

If you want, I can add some advanced CI to your repo in a PR. Let me know if you want that.

  • Do you want to enable auto-formatting?
  • Do you want packaged or independent (I recommend packaged because I can send updates)?
@xraver
Copy link
Owner

xraver commented Dec 20, 2020

Dear
thank for your proposal.
every kind of help in my project is more than welcome.
I'm not familiar with github action... can you explain me what improvement are you able to provide to this project?
thanks

@KTibow
Copy link
Contributor Author

KTibow commented Dec 20, 2020

When you accept my PR, it'll add a section to the top of your repo, Actions. The GitHub Action can automatically format your code, so it looks nicer, and is easier to understand. It also can automatically send you an email if you write invalid code without realizing. And finally, it can give you suggestions for how to improve your code's style.

@xraver
Copy link
Owner

xraver commented Dec 21, 2020 via email

@xraver
Copy link
Owner

xraver commented Dec 21, 2020

Dear, you have done a very great job!
you have merged my old action from hacs with this new one.
thank you very much!
when i'll have time i'll study git actions :) seems are very powerfull

@xraver xraver added the enhancement New feature or request label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants