Skip to content

Conversation

malor
Copy link
Member

@malor malor commented May 26, 2024

  • We don't call delete() and update() outside of tests, which technically makes the two "dead" code

  • clone_from() is a bit opinionated, but it basically allows to have a clever Clone implementation that avoids memory allocations. See https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones

  • ikalnytskyi/action-setup-postgres@v1 no longer works on Mac OS images

malor added 2 commits May 26, 2024 18:42
* We don't call delete() and update() outside of tests, which technically
makes the two "dead" code

* clone_from() is a bit opinionated, but it basically allows to have
a clever Clone implementation that avoids memory allocations. See
https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones
It looks like v1 no longer works on Mac OS images.
@malor malor requested a review from ikalnytskyi May 26, 2024 18:03
@malor malor merged commit 533dfb5 into master May 27, 2024
@malor malor deleted the deps-and-warnings branch May 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants