Do not pass node_modules to Babel #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to pass Joi and its dependencies to Babel because they are distributing as ES6 libraries, not as ES5. While browsers are usually good enough to eat this, UglifyJS fails to process non ES5 blocks. Fortunately, we've upgraded to webpack 4 that comes with new version of uglifyjs-webpack-plugin that depends on uglify-es module rather than on uglify-js. The former supports non ES5 blocks so from now on any non ES5 code processed by uglifyjs-webpack-plugin will be transpiled to ES5.
lotrien
approved these changes
May 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to pass Joi and its dependencies to Babel because they are
distributing as ES6 libraries, not as ES5. While browsers are usually
good enough to eat this, UglifyJS fails to process non ES5 blocks.
Fortunately, we've upgraded to webpack 4 that comes with new version of
uglifyjs-webpack-plugin that depends on uglify-es module rather than on
uglify-js. The former supports non ES5 blocks so from now on any non ES5
code processed by uglifyjs-webpack-plugin will be transpiled to ES5.