[React useMemo] Add useMemo hook for syntaxes #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalnytskyi
approved these changes
Jun 19, 2019
| @@ -70,14 +70,14 @@ const NewSnippet = ({ dispatch, history, syntaxes }) => { | |||
| const handleSyntax = syntax => ({ syntax }) | |||
| const handleContent = content => ({ content }) | |||
|
|
|||
| const getSyntaxes = () => { | |||
| const memoizedSyntaxes = useMemo(() => { | |||
There was a problem hiding this comment.
What's the benefit of using useMemo()?
There was a problem hiding this comment.
useMemo will memorize result of passed function and will be re-rendered only if syntaxes has changed.
| @@ -15,21 +15,21 @@ const useForm = (cb, validate) => { | |||
| } | |||
| }, [error, isSubmitting]) | |||
|
|
|||
| const handleSubmit = useCallback(e => { | |||
There was a problem hiding this comment.
Why useCallback has been removed?
There was a problem hiding this comment.
in our case without second parameter this hook does not have sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.