Fix Snippet route #159
Merged
Fix Snippet route #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of xsnippet-api uses alphanumeric slugs instead of integer identifiers, so we need to update the regex accordingly to work with all possible snippet id values.
ikalnytskyi
approved these changes
Jun 6, 2021
malor
added a commit
that referenced
this pull request
Jun 6, 2021
#159 accidentally broke routing: apparently, React renders *all* matched routes by default, and so our new snippet id regexp does not play nicely with other routes like /about or /recent, which are now matched as well, because both "about" and "recent" are valid snippet ids. The solution is to use the https://reactrouter.com/web/api/Switch component which renders the *first* matched Route as opposed to all of them.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of xsnippet-api uses alphanumeric slugs instead of integer identifiers, so we need to update the regex accordingly to work with all possible snippet id values.