Make Plain text as default and fix active index on search #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far <Syntaxes> component is a little bit overcomplicated and requires thorough reading throughout the code to get its idea. In order to simplify things and make them more general, let's split the component into two: * general ListBox * general ListBoxWithSearch and encapsulate domain logic (syntaxes) in NewSnippet component. Co-Authored-By: Olha Kurkaiedova <olya.kurkaedova@gmail.com> Co-Authored-By: Ihor Kalnytskyi <ihor@kalnytskyi.com> Closes: #42 Closes: #45
ikalnytskyi
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that syntax is always set was decided to make Plain Text
option the default one. To improve UX for search lang this commit
includes changes on active item, so now it keeps previously clicked value
and gets first from the list if no previous value were provided.