Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes in tests required to test xcoll in xsuite workflows #23

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

szymonlopaciuk
Copy link
Contributor

Description

Minor fixes, mostly in tests, in preparation for setting up automated testing for xcoll.

  • changed some tolerances in test_everest.py
  • changed an assertion in test_lossmap.py, where in the cases when ignore_crystals=False there was more elements.
  • made some adaptations to tests to make them pass on GPU (including excluding two in test_collimator_elements.py
  • changed abs to fabs where appropriate
  • fixed the usage of @retry() (currently the brackets are necessary even if no parameters are provided, otherwise strange things happen...)
  • specified extras installation for tests as for the other xsuite packages. When pip install xcoll[tests] is run, pytest and ruamel.yaml are also installed.
  • made tests independent from the current working directory.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@freddieknets freddieknets changed the base branch from main to release0.2.2 June 15, 2023 14:54
@freddieknets freddieknets merged commit a829d56 into xsuite:release0.2.2 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants