Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InitialPart #53

Merged
merged 8 commits into from
Feb 26, 2024
Merged

InitialPart #53

merged 8 commits into from
Feb 26, 2024

Conversation

simoneotelie
Copy link
Contributor

Description

Rewrote the functions for generating particles on a collimator so that they are mostly independent from the CollimationManager.
I think the plots look like they should?

Closes # .

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@freddieknets freddieknets changed the base branch from InitialPart to NoMoreManager February 26, 2024 08:57
@freddieknets freddieknets merged commit 0afd2af into xsuite:NoMoreManager Feb 26, 2024
@simoneotelie simoneotelie deleted the InitialPart branch May 29, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants