-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more manager! #73
Merged
Merged
No more manager! #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t table more robust; works correctly for BlackAbsorber.
…epared small details for recording of crystals.
…ing of variables.
…wever this currently makes test_elements fail)
…sue when expanding an array (in calculate_overlap) -> this was solved by the realisation that the array will always be allocated large enough in our case anyway
…ackCrystal, and made jaw= and gap= sign-dependent when setting a single-sided collimator.
…e for EverestCrystal)
…und the front corner -> not done consistently.
…moved some superflous geometry from struct (though some is left for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request collects lots of changes that were scattered over different branches (with the most important one being the slimming down of the manager). All changes will be detailed in the upcoming release notes.
Mandatory:
Optional: