Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean stop of flukaserver to remove temporary fluka_xxx directory #79

Closed
wants to merge 68 commits into from

Conversation

luillo76
Copy link

Description

  • clean stop of flukaserver to remove temporary fluka_xxx directory
  • reduce output in fluka_log_unit

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

freddieknets and others added 30 commits June 15, 2023 05:26
…0 for both sending particles and receiving particles. Desactivate server launch from xsuite (debugging purposes) + Uncomment functions from SixTrack and fix related types in common_modules + Modifications in pyfluka leading to solve the issues (follow what is done in SixTrack main_cr)
…thon engine is shutting down, but explicitely from example.py. This allows a complete and clean server & connection closure. + The message on "did you compile?" is only relevant the first time pyfluka is imported.
…s set in main_cr.f90). Instead, in XSuite, these variables were not set, leading to erroneous BRH0 (0), leading to all particles to be cut. Can now receive particles. TO DO: while those values in common_modules.f90 are not presently used, they will be used when the kernel_element in mod_fluka.f90 are uncommented, so maybe should set them in mod_common as well, instead of only passing them as parameters. TO DO 2: The next crash to explore happens with total particles >= 500, segfault in mgdraw.
…and from 1 in FlukaIO. Hence, was wrongly passing a 0 index as particle/parentId, hence issue with IDPIDP and IDPGEN (from mdstck.f) in mgdraw.f. Now sending / reception fully fly with even 20 000 particles.
…and from 1 in FlukaIO. Hence, was wrongly passing a 0 index as particle/parentId, hence issue with IDPIDP and IDPGEN (from mdstck.f) in mgdraw.f
…mory allocation done under the hood, contrary to fluka_mod_init). This allows to have the starting id of the received particles sparting from npart + 1, instead of inelegantly n_alloc + 1
freddieknets and others added 25 commits September 24, 2023 01:13
…ent but the primary particle -> the original first impact). Parents have wrong energy deposited; particles are not always traceable. To be improved.
@freddieknets freddieknets changed the base branch from FLUKA to NewFLUKA June 12, 2024 07:45
@freddieknets freddieknets force-pushed the NewFLUKA branch 2 times, most recently from 41b9bc5 to 44894ff Compare July 23, 2024 13:43
@freddieknets
Copy link
Collaborator

Closing this PR as it is based on the old (now removed) FLUKA branch. The aimed functionality of this PR is now provided in the NewFLUKA branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants