Update CMakeLists to correctly find pybind11 alias targets #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional TARGET check in the root cmake file to correctly find the pybind11 alias targets.
|
I wonder if this is not more an issue of pybind11? Why is the target not defined? |
nickrobison-usds
added a commit
to nickrobison-usds/mobility-cpp
that referenced
this pull request
Sep 15, 2020
Add the required submodules for python integration. We're using our own branch of xtensor-python, while we wait for the [PR](xtensor-stack/xtensor-python#242) to be merged.
nickrobison-usds
added a commit
to nickrobison-usds/mobility-cpp
that referenced
this pull request
Sep 15, 2020
Add the required submodules for python integration. We're using our own branch of xtensor-python, while we wait for the [PR](xtensor-stack/xtensor-python#242) to be merged.
nickrobison-usds
added a commit
to nickrobison-usds/mobility-cpp
that referenced
this pull request
Sep 18, 2020
Add the required submodules for python integration. We're using our own branch of xtensor-python, while we wait for the [PR](xtensor-stack/xtensor-python#242) to be merged.
nickrobison-usds
added a commit
to nickrobison-usds/mobility-cpp
that referenced
this pull request
Sep 29, 2020
Add the required submodules for python integration. We're using our own branch of xtensor-python, while we wait for the [PR](xtensor-stack/xtensor-python#242) to be merged.
|
(rerunning CI) |
tdegeus
approved these changes
May 18, 2021
|
Do we care about the CI configuration failures @JohanMabille ? (Also maybe we should fix, what's holding me back is that I'm more of a GitHub Action person ;)) |
|
rerunning CI |
Yes we do ;) |
|
That's why I fixed them ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building xtensor-python and pybind11 as cmake submodule projects, the pybind aliased targets are not discovered correctly.
This PR adds an additional check to also look for the
pybind11:headersaliased target and set the values accordingly.