Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow xterm.js to exist and receive/send data before it's attached to the DOM #266

Closed
Tyriar opened this issue Sep 14, 2016 · 2 comments
Closed

Allow xterm.js to exist and receive/send data before it's attached to the DOM #266

Tyriar opened this issue Sep 14, 2016 · 2 comments
Labels
type/enhancement Features or improvements to existing features

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2016

In v1.6 of VS Code the newly introduced Terminal API will allow processes to exist before the actual terminal panel/element is created. While this is currently possible, xterm cannot be initialized until the element exists, which means the output before the element is attached is lost. It would be good if everything was functional only no rendering took place until open is invoked.
@Tyriar Tyriar added the feature label Sep 14, 2016
This was referenced Sep 14, 2016
Closed
Closed
@parisk
Copy link
Contributor

parisk commented Sep 15, 2016

Sounds legit. Would it make sense to export the renderer into its own module for this?

@Tyriar
Copy link
Member Author

Tyriar commented Sep 15, 2016

Ideally, not sure how difficult that is right now

This was referenced Sep 18, 2016
Closed
Closed
@Tyriar Tyriar mentioned this issue Oct 7, 2016
Closed
@Tyriar Tyriar mentioned this issue Nov 2, 2016
Closed
@Tyriar Tyriar mentioned this issue Feb 1, 2017
Merged
Tyriar added a commit that referenced this issue Feb 1, 2017
@Tyriar
Add null check on Terminal.element
833eb52 
Since the Terminal can be used now before being attached, we should check element on destroy.

Related to #266
@Tyriar Tyriar mentioned this issue Feb 1, 2017
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Feb 1, 2017
@Tyriar
Add null check on Terminal.element
d534e30 
Since the Terminal can be used now before being attached, we should check element on destroy.

Related to xtermjs#266
@Tyriar Tyriar mentioned this issue Mar 15, 2017
Closed
@johnpoth johnpoth mentioned this issue Feb 8, 2018
Closed
@Tyriar Tyriar added the type/enhancement Features or improvements to existing features label Apr 4, 2018
@the21st the21st mentioned this issue Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parisk @Tyriar