Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new vscode serverReadyAction #1968

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Use new vscode serverReadyAction #1968

merged 1 commit into from
Mar 23, 2019

Conversation

bmf-ribeiro
Copy link
Contributor

Adding the new VS Code option to the project launch.json file

Reference
Server Ready Action

I'm using it and it works, what do you guys think?

Tyriar
Tyriar approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I didn't know about this 😃

I guess even better would be a composite debug target which launched the server and client targets.

@Tyriar Tyriar added this to the 3.13.0 milestone Mar 23, 2019
@Tyriar Tyriar merged commit 8b6d564 into xtermjs:master Mar 23, 2019
@bmf-ribeiro bmf-ribeiro deleted the new-feature branch November 27, 2019 17:50
@renovate renovate bot mentioned this pull request Jun 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bmf-ribeiro @Tyriar