Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set row height when char size is changed #680

Merged
merged 3 commits into from
Jun 10, 2017
Merged

Set row height when char size is changed #680

merged 3 commits into from
Jun 10, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 6, 2017

When zoomed in line-height and actual rendered row height differs. This
can be seen in the viewport being too large when zoomed in right now
but also has additional impacts in the new selection model #207

Fixes #679

@Tyriar
Set row height when char size is changed
603f22a 
When zoomed in line-height and actual rendered row height differs. This
can be seen in the viewport being too large when zoomed in right now
but also has additional impacts in the new selection model xtermjs#207
@Tyriar Tyriar added this to the 2.8.0 milestone Jun 6, 2017
@Tyriar Tyriar self-assigned this Jun 6, 2017
@Tyriar Tyriar requested a review from parisk June 6, 2017 21:33
@Tyriar Tyriar mentioned this pull request Jun 6, 2017
Merged
64 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.986% when pulling 46f6fd1 on Tyriar:set_row_height_explicitly into 4b72791 on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.986% when pulling 46f6fd1 on Tyriar:set_row_height_explicitly into 4b72791 on sourcelair:master.

parisk
parisk previously requested changes Jun 10, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts and it's good to go 🚀 .

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.497% when pulling 0950369 on Tyriar:set_row_height_explicitly into a889fef on sourcelair:master.

@Tyriar Tyriar dismissed parisk’s stale review June 10, 2017 17:25

Conflicts resolved

@Tyriar Tyriar merged commit c33814a into xtermjs:master Jun 10, 2017
@Tyriar Tyriar deleted the set_row_height_explicitly branch June 10, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk left review comments

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk