Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to navigate using keyboard after search focus #8

Closed
radmen opened this issue Dec 14, 2017 · 8 comments
Closed

Not possible to navigate using keyboard after search focus #8

radmen opened this issue Dec 14, 2017 · 8 comments

Comments

@radmen
Copy link
Contributor

radmen commented Dec 14, 2017

Problem

Qian seems to be focused strongly on using keyboard.
Yet I find it really annoying that it's not possible to select file with arrows or even change directory with Cmd+UP/Cmd+LEFT/Cmd+RIGHT.

I've tried to unfocus search by hitting Tab key however it didn't fix anything.
Mentioned shortcuts work only when I click somewhere on the file listing

What I expect

I think that navigation shortcuts should work even if search bar is focused.

More informations (for example, specific context or steps to reproduce)

  • focus on search bar using [Tab]
  • type something
  • open directory using / key
  • try to go back using Cmd-LEFT
@xvw
Copy link
Owner

xvw commented Dec 14, 2017

Actually, Qian does not allow "the selection" of a file. (It is in my milestone). So the goal of CMD+left|right is only to navigate in the history. It is a little bit sad, but those shortcuts does not works when the searchbar is focused.

I will write an hotfix to "unfocus" the search field when Qian performs a directory change.

Thanks for your feedback !

@radmen
Copy link
Contributor Author

radmen commented Dec 14, 2017

Actually, Qian does not allow "the selection" of a file.

Yeah, it's bit frustrating however for me it's enough that shortcuts for opening the first result will work :)

I will write an hotfix to "unfocus" the search field when Qian performs a directory change.

It's not possible to catch those shortcuts when search is focused?

@xvw
Copy link
Owner

xvw commented Dec 14, 2017

Hmm I will try (for the second point)

@xvw
Copy link
Owner

xvw commented Dec 14, 2017

Actually, I have change the shortcuts : https://github.com/xvw/qian/releases/tag/v1.2.1
(I think it is a first step :), what do you think about this ?)

@radmen
Copy link
Contributor Author

radmen commented Dec 15, 2017

Actually, I have change the shortcuts

is there defined anywhere list of those shortcuts? Seems like the ones from README are not working anymore.

@radmen
Copy link
Contributor Author

radmen commented Dec 15, 2017

ah, silly me. Found them! Can confirm that those shortcuts work.

They seem to be bit unintuitive, yet I'll give them try.

@xvw
Copy link
Owner

xvw commented Dec 15, 2017

Can I Close this issue ? (I understand your point about the shortcuts. In the comming Day, I Will try to find a solution !)

@radmen
Copy link
Contributor Author

radmen commented Dec 15, 2017

I think we can close it :)

@radmen radmen closed this as completed Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants