-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve analytics macros livedata UI #42 #37
Conversation
application-analytics-ui/src/main/resources/Analytics/Code/AnalyticsTranslations.xml
Outdated
Show resolved
Hide resolved
application-analytics-ui/src/main/resources/Analytics/Code/AnalyticsTranslations.xml
Outdated
Show resolved
Hide resolved
* - Added support for hovering over the columns to get some info. - Modified the macro for converting seconds into DD:HH::MM:SS to use jodatime
- Added categories & translation for rendering
- Revert file
application-analytics-ui/src/main/resources/Analytics/Code/AnalyticsTranslations.xml
Outdated
Show resolved
Hide resolved
application-analytics-ui/src/main/resources/Analytics/Code/AnalyticsTranslations.xml
Outdated
Show resolved
Hide resolved
application-analytics-ui/src/main/resources/Analytics/Code/AnalyticsTranslations.xml
Outdated
Show resolved
Hide resolved
application-analytics-ui/src/main/resources/Analytics/Code/Macros/Configurations.xml
Outdated
Show resolved
Hide resolved
Can you also add a screenshot for how this looks? |
- Reordered the translation keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the livedata columns hints, that is fixed on newer XWiki versions as part of https://jira.xwiki.org/browse/XWIKI-21434, I know you said that it can be added from the translation keys. So just to confirm, those of analytics.mostViewedPages.header.columnTitle.hint
form are for these descriptions, right? Could you add a ss from a newer version of XWiki, so show this change as well?
application-analytics-ui/src/main/resources/Analytics/Code/AnalyticsTranslations.xml
Outdated
Show resolved
Hide resolved
application-analytics-ui/src/main/resources/Analytics/Code/AnalyticsTranslations.xml
Outdated
Show resolved
Hide resolved
* - Added translations for parameters
* - Fixed typos
I have just one remark, after looking at the |
I believe that the days are necessary because in a real scenario with multiple users, the time will accumulate rapidly, eventually spanning several days. |
Ok, so this is the sum for all users. Then it looks good! |
Don't forget to mention on the issue the XWiki versions where the title attribute is displayed |
[NEW]
[IMPROVEMENTS]