Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve analytics macros livedata UI #42 #37

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Conversation

Farcasut
Copy link
Collaborator

@Farcasut Farcasut commented Sep 25, 2023

[NEW]

  • New macro to calculate the time in the DD:HH:MM:SS format from seconds

[IMPROVEMENTS]

  • Ordered the translations in alphabetical order
  • Add all the macros to the analytics macro category

* - Ordered the translation page
- Time converted from seconds to DD:HH:MM:SS format
@Farcasut Farcasut self-assigned this Sep 25, 2023
@Farcasut Farcasut linked an issue Sep 25, 2023 that may be closed by this pull request
@Farcasut Farcasut linked an issue Oct 5, 2023 that may be closed by this pull request
@Farcasut Farcasut changed the title MISC Improve analytics macros livedata UI #42 & Reordering translations to be in alphabetical order. #36 Oct 5, 2023
@Farcasut Farcasut marked this pull request as draft October 5, 2023 13:05
@Farcasut Farcasut changed the title Improve analytics macros livedata UI #42 & Reordering translations to be in alphabetical order. #36 Improve analytics macros livedata UI #42 Oct 8, 2023
*
- Added support for hovering over the columns to get some info.
- Modified the macro for converting seconds into DD:HH::MM:SS to use jodatime
@Farcasut Farcasut marked this pull request as ready for review October 18, 2023 09:51
@Farcasut Farcasut requested a review from oanalavinia October 18, 2023 09:51
@Farcasut Farcasut marked this pull request as draft October 18, 2023 10:12
@Farcasut Farcasut marked this pull request as ready for review October 18, 2023 11:22
@oanalavinia
Copy link
Collaborator

Can you also add a screenshot for how this looks?

- Reordered the translation keys
@Farcasut Farcasut requested a review from oanalavinia October 20, 2023 13:53
@Farcasut
Copy link
Collaborator Author

image
image

Copy link
Collaborator

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the livedata columns hints, that is fixed on newer XWiki versions as part of https://jira.xwiki.org/browse/XWIKI-21434, I know you said that it can be added from the translation keys. So just to confirm, those of analytics.mostViewedPages.header.columnTitle.hint form are for these descriptions, right? Could you add a ss from a newer version of XWiki, so show this change as well?

* - Added translations for parameters
@Farcasut
Copy link
Collaborator Author

Farcasut commented Oct 25, 2023

Yes, the analytics.mostViewedPages.header.columnTitle.hint is the translation key.
Preview
image

@Farcasut Farcasut requested a review from oanalavinia October 25, 2023 06:56
@oanalavinia
Copy link
Collaborator

I have just one remark, after looking at the time spent column from the above screenshot. I'm thinking that you should just use the HH:MM:SS date format. For me it looks like too much to have also the days, when it's not a very common thing. It just adds a trifling value. WDYT?

@Farcasut
Copy link
Collaborator Author

I have just one remark, after looking at the time spent column from the above screenshot. I'm thinking that you should just use the HH:MM:SS date format. For me it looks like too much to have also the days, when it's not a very common thing. It just adds a trifling value. WDYT?

I believe that the days are necessary because in a real scenario with multiple users, the time will accumulate rapidly, eventually spanning several days.

@oanalavinia
Copy link
Collaborator

Ok, so this is the sum for all users. Then it looks good!

@oanalavinia
Copy link
Collaborator

Don't forget to mention on the issue the XWiki versions where the title attribute is displayed

@Farcasut Farcasut merged commit 70de63b into xwikisas:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve analytics macros livedata UI
2 participants