Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SVG isn't exported by default when doing a PDF export, although the property is in place #131

Closed
ane-gabriela opened this issue Apr 10, 2020 · 2 comments · Fixed by #141
Closed

The SVG isn't exported by default when doing a PDF export, although the property is in place #131

ane-gabriela opened this issue Apr 10, 2020 · 2 comments · Fixed by #141
Assignees
@oanalavinia
Labels
Priority: Critical Type: Bug
Milestone
1.13.1

Comments

@ane-gabriela
Copy link

Steps to reproduce:

  1. Create a new Diagram
  2. Add some shapes
  3. Add a word in each shape
  4. Select the word from one of the shapes
  5. Click on the Link... button below Insert from the right panel
  6. Select a wiki page > Apply
  7. Click Save & View
  8. Access More actions > Export > Export as PDF
  9. Deselect all options > Export

Expected results: The diagram is exported as SVG, as after #102 this is the default selection (to also include links)

Actual results: The diagram is exported as png instead of SVG. When editing in object mode the SVG is correctly set.
The workaround is to just save the page in Object mode - without making any change and then the export works properly, exporting as SVG.

Environment: XWiki 11.10.4 with MySQL 5.7 and Chrome 81, Diagram Application (Pro) 1.13

ObjectMode
First Export - xwiki_Diagram_Admin+Diagram_WebHome.pdf
@ane-gabriela ane-gabriela added this to the 1.14 milestone Apr 10, 2020
@oanalavinia oanalavinia self-assigned this Apr 10, 2020
@mflorea
Copy link
Collaborator

mflorea commented Apr 10, 2020

Looks like an issue with choosing the default value when the exportUsingSVG is not specified. Should default to true (SVG export).

@ane-gabriela
Copy link
Author

Reproduced also on XWiki 9.11, Chrome 81

oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue May 6, 2020
@oanalavinia
The SVG isn't exported by default when doing a PDF export, although t…
c0438e6 
…he property is in place xwikisas#131

* use svg as default from code since we do not set exportUsingSVG at diagram creation step and defaultValue has only the purpose of prefill before the first save.
@oanalavinia oanalavinia mentioned this issue May 6, 2020
Merged
oanalavinia added a commit that referenced this issue May 7, 2020
@oanalavinia
The SVG isn't exported by default when doing a PDF export, although t…
83f1ef5 
…he property is in place #131 (#141)

* use svg as default from code since we do not set exportUsingSVG at diagram creation step and defaultValue has only the purpose of prefill before the first save (checking object mode after creating the diagram will leave the feeling that it was already set for svg)
@oanalavinia oanalavinia modified the milestones: 1.14, 1.13.1 May 7, 2020
@oanalavinia oanalavinia linked a pull request May 8, 2020 that will close this issue
The SVG isn't exported by default when doing a PDF export, although t… #141
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Critical Type: Bug
Projects
None yet
Milestone
1.13.1
3 participants
@mflorea @oanalavinia @ane-gabriela