Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Only user with customize_publish cap can publish snapshot #74

Merged
merged 6 commits into from
Aug 22, 2016

Conversation

PatelUtkarsh
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 16, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling d6885ff on bugfix/customize-publish into 856d135 on develop.

@PatelUtkarsh
Copy link
Member Author

@valendesigns Should we also hide schedule icon in customizer if a user can not publish snapshot?
If do that we might need to allow it on #19 for naming and hide just the calendar UI.

@westonruter westonruter added this to the 0.5.1 milestone Aug 16, 2016
@westonruter
Copy link
Contributor

Yes, if the user cannot publish then the scheduling UI should be hidden, I think. It should just allow them to Submit for review (as pending) I should think.

@valendesigns
Copy link
Contributor

valendesigns commented Aug 16, 2016

We should definitely close any potential unauthorized means of publishing but retain the ability to see the UI and submit as pending for review.

The client's QA team needs to test features including the scheduling UI so it should not be hidden but limited to what a normal unauthorized user would experience. That means the UI needs to handle a situation where the user doesn't have the privileges, so a save would submit for review (pending).

cc @PatelUtkarsh @westonruter

@westonruter
Copy link
Contributor

@valendesigns maybe we're saying the same thing, but contributor users cannot assign a date to their posts in the WP admin, so I should think that would apply to contributors in the customizer as well. If they can only create posts with draft or pending status then they shouldn't be able to assign future dates (and a future status) as well:

add_new_post_ _wordpress_develop_5_ _wordpress

@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling 7aee799 on bugfix/customize-publish into 856d135 on develop.

@PatelUtkarsh PatelUtkarsh changed the title [WIP] Only user with customize_publish cap can publish snapshot Only user with customize_publish cap can publish snapshot Aug 17, 2016
@coveralls
Copy link

coveralls commented Aug 19, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling bcc515f on bugfix/customize-publish into 856d135 on develop.

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling b542128 on bugfix/customize-publish into 089cf81 on develop.

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage increased (+0.1%) to 90.935% when pulling f5afffa on bugfix/customize-publish into 089cf81 on develop.

@westonruter westonruter merged commit ff20c33 into develop Aug 22, 2016
@westonruter westonruter deleted the bugfix/customize-publish branch August 22, 2016 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants