New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only user with customize_publish cap can publish snapshot #74

Merged
merged 6 commits into from Aug 22, 2016

Conversation

Projects
None yet
4 participants
@PatelUtkarsh
Collaborator

PatelUtkarsh commented Aug 16, 2016

No description provided.

@coveralls

This comment has been minimized.

coveralls commented Aug 16, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling d6885ff on bugfix/customize-publish into 856d135 on develop.

@PatelUtkarsh

This comment has been minimized.

Collaborator

PatelUtkarsh commented Aug 16, 2016

@valendesigns Should we also hide schedule icon in customizer if a user can not publish snapshot?
If do that we might need to allow it on #19 for naming and hide just the calendar UI.

@westonruter westonruter added this to the 0.5.1 milestone Aug 16, 2016

@westonruter

This comment has been minimized.

Contributor

westonruter commented Aug 16, 2016

Yes, if the user cannot publish then the scheduling UI should be hidden, I think. It should just allow them to Submit for review (as pending) I should think.

@valendesigns

This comment has been minimized.

Member

valendesigns commented Aug 16, 2016

We should definitely close any potential unauthorized means of publishing but retain the ability to see the UI and submit as pending for review.

The client's QA team needs to test features including the scheduling UI so it should not be hidden but limited to what a normal unauthorized user would experience. That means the UI needs to handle a situation where the user doesn't have the privileges, so a save would submit for review (pending).

cc @PatelUtkarsh @westonruter

@westonruter

This comment has been minimized.

Contributor

westonruter commented Aug 16, 2016

@valendesigns maybe we're saying the same thing, but contributor users cannot assign a date to their posts in the WP admin, so I should think that would apply to contributors in the customizer as well. If they can only create posts with draft or pending status then they shouldn't be able to assign future dates (and a future status) as well:

add_new_post_ _wordpress_develop_5_ _wordpress

@coveralls

This comment has been minimized.

coveralls commented Aug 17, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling 7aee799 on bugfix/customize-publish into 856d135 on develop.

@PatelUtkarsh PatelUtkarsh changed the title from [WIP] Only user with customize_publish cap can publish snapshot to Only user with customize_publish cap can publish snapshot Aug 17, 2016

@coveralls

This comment has been minimized.

coveralls commented Aug 19, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling bcc515f on bugfix/customize-publish into 856d135 on develop.

@coveralls

This comment has been minimized.

coveralls commented Aug 22, 2016

Coverage Status

Coverage decreased (-0.1%) to 90.652% when pulling b542128 on bugfix/customize-publish into 089cf81 on develop.

@coveralls

This comment has been minimized.

coveralls commented Aug 22, 2016

Coverage Status

Coverage increased (+0.1%) to 90.935% when pulling f5afffa on bugfix/customize-publish into 089cf81 on develop.

@westonruter westonruter merged commit ff20c33 into develop Aug 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the bugfix/customize-publish branch Aug 22, 2016

@westonruter westonruter referenced this pull request May 26, 2017

Merged

Add DELETE endpoint #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment