Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$TERM rendering bug #235

Closed
anasrar opened this issue Sep 1, 2022 · 6 comments · Fixed by #247
Closed

$TERM rendering bug #235

anasrar opened this issue Sep 1, 2022 · 6 comments · Fixed by #247

Comments

@anasrar
Copy link

anasrar commented Sep 1, 2022

some rendering bug occur in terminal because $TERM

alacritty

image
process cursor not visible, try run with TERM=xterm-kitty gotop

kitty

image
process cursor render bug, try run with TERM=xterm gotop

tmux

if you get some error like this in tmux session

07:55:56 remote.go:74: Remote: no remote URL provided; disabling extension
07:55:56 temp_nix.go:35: error opening smart info for sda: unknown drive type
07:55:56 temp_nix.go:35: error opening smart info for sdb: unknown drive type
termbox: error while reading terminfo data: termbox: unsupported terminal

it because gotop not support your current session $TERM in tmux, try run with TERM=xterm-kitty gotop

gotop version:

gotop v4.1.4 (20220715T163833)

OS/Arch:

5.19.5-arch1-1 GNU/Linux

Terminal emulator:

alacritty and kitty

Any relevant hardware info:

-

tmux version:

tmux 3.3a

@cmalvi
Copy link

cmalvi commented Sep 3, 2022

same with gnome terminal

@rare-magma
Copy link

I believe this bug first appeared after the update of some libraries done in https://github.com/xxxserxxx/gotop/pull/221/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

@KBeDevel
Copy link

I have this issue in v4.2.0.

My environment:

Terminals: Konsole, Kitty
OS: Fedora 38 KDE Spin
Install method: Homebrew

@gardockt
Copy link

There was no release since the fix was merged, so v4.2.0 is still affected. Currently the only way to get the fixed version is to build the program manually.

@KBeDevel
Copy link

@gardockt Yes, local build using latest commit (3e50a67) seems to work perfect.

@xxxserxxx
Copy link
Owner

Yeah, I will probably do a minor version bump release for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants