Add support for building on Apple Silicon #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't build logging_arm64 when on darwin, MacOS on arm64 does not have a dup3 syscall Remove \!arm64 from logging_other, so builds work on MacOS on arm64 (Apple Silicon)
6 tasks
areese
pushed a commit
to areese/homebrew-core
that referenced
this pull request
Jun 14, 2021
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jun 14, 2021
…pple Silicon Closes #79314. Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: Michael Cho <20700669+cho-m@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
|
This will be released with v4.1.2 -- dispite the long delay, thanks for your patch. Accepting this required finding and integrating a newer cross-compile CGO build chain, and because I can't test this myelf I've been cautious about making the change. |
|
@xxxserxxx thank you, I'll update the homebrew formula to stop patching this when v4.1.2 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't build logging_arm64 when on darwin, MacOS on arm64 does not have a dup3 syscall
Remove !arm64 from logging_other, so builds work on MacOS on arm64 (Apple Silicon)