Created Spanish translation 🇪🇸 #188
Conversation
translations/dicts.go
Outdated
| // Code generated for package translations by go-bindata DO NOT EDIT. (@generated) | ||
| // sources: |
There was a problem hiding this comment.
This file in general has a lot of spurious diffs, which I tend to avoid in my projects for multiple reasons. @xxxserxxx do you mind those?
I use github.com/go-bindata/go-bindata 3.1.3 and I dont have this problem. (to be fair there are multiple forks of this tool it's annoying) Which one did you use?
If you want a patch see 5922288
There was a problem hiding this comment.
I prefer to minimize diffs for probably the same reasons, but I'm not going to force people to correct them. Thanks for doing that, @lourkeur, and thank you @donPatino for the translation. I'll try to find time to get it reviewed and merged this weekend.
I have a version ready to go out that eliminates go-bindata (given the recently added official Go embed functionality); I just haven't had time to put a release together. That should reduce the amount of spurious diffs.
There was a problem hiding this comment.
I followed the install instructions in github.com/go-bindata/go-bindata & it seems to have installed 3.1.2 by default. I have now built 3.1.3 on my development machine; how should I go about correcting this?
- Create a new commit using go-bindata 3.1.3
- Remove current commit & create a new one using go-bindata 3.13
There was a problem hiding this comment.
option number two, replacing the commit, (or equivalently the --amend commit option) is preferred.
There was a problem hiding this comment.
Great, will amend.
Using version 3.1.3 resolved most of the spurious diffs; except the changes to the FileMode are still generated as "436" rather than "420". Any suggestions as to what is causing this?
Example:
info := bindataFileInfo{name: "de_DE.toml", size: 7223, mode: os.FileMode(436), modTime: time.Unix(1625599
921, 0)}
go-bindata versions:
$ go-bindata --version
go-bindata 3.1.3 (Go runtime go1.14).
Copyright (c) 2010-2013, Jim Teeuwen.
Command I am running (from the root of the project):
$ go generate
Please let me know if there is additional information that could help with this.
There was a problem hiding this comment.
It's unix permissions on the files. 420 = 0644, 436 = 0664. That's a trivial matter, don't worry too much about permanently fixing it on your end. We can handle this manually.
translations/dicts/es.toml
Outdated
| battery | ||
| kitchensink""" | ||
| # TRANSLATORS: Please don't translate the colorcheme **names** | ||
| colorschemes = """Built-in colorschemes: |
There was a problem hiding this comment.
| colorschemes = """Built-in colorschemes: | |
| colorschemes = """Esquemas de colores: |
same
translations/dicts/es.toml
Outdated
| - b: alternar entre mbps y bytes escalados por segundo | ||
| """ | ||
| # TRANSLATORS: Please don't translate the layout **names** | ||
| layouts = """Built-in layouts: |
translations/dicts/es.toml
Outdated
| vice | ||
| nord""" | ||
| # TRANSLATORS: Please don't translate the widget **names** | ||
| widgets = """Widgets that can be used in layouts: |
translations/dicts/es.toml
Outdated
| # TRANSLATORS: Please don't translate the colorcheme **names** | ||
| colorschemes = """Built-in colorschemes: | ||
| default | ||
| default-dark (for white background) |
|
Thank you for the suggestions @lourkeur, I obviously missed some of the text that still needs translation. I will be working on implementing the suggested changes. |
|
Implemented suggested changes, please let me know if any further changes need to be made. |
|
Thank you, both of you. |
Per #120
I am a native Spanish speaker, and attempted to use proper Spanish intelligible to Spanish speakers worldwide.
Feel free to provide feedback, if any changes are needed before merge.
Also used @lourkeur French contribution as a template.