Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use http params to specify clickhouse data format #180

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

save-my-heart
Copy link
Contributor

It is very disgusting to rewrite sql with 'FORMAT TabSeparatedWithNamesAndTypes' and it may cause some other problems.
Instead, we can add a http params to solve it easily.
see: https://github.com/ClickHouse/ClickHouse/blob/ab9fc572d536ec9b3b7b2ac8628a3824bdeeda4c/src/Server/HTTPHandler.cpp#L734

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 83.795% when pulling 5975561 on save-my-heart:master into f6444db on xzkostyan:master.

@xzkostyan xzkostyan merged commit dfd9ba3 into xzkostyan:master Jun 17, 2022
@villebro
Copy link

villebro commented Sep 7, 2022

It would be great if this fix could be backported to the 0.1 version of clickhouse-sqlalchemy for projects that rely on sqlalchemy<1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query wrongly gets appended "FORMAT TabSeparatedWithNamesAndTypes"
4 participants