fix(sqllab):clickhouse result no column header#20325
Closed
wengieeee wants to merge 1 commit intoapache:masterfrom
Closed
fix(sqllab):clickhouse result no column header#20325wengieeee wants to merge 1 commit intoapache:masterfrom
wengieeee wants to merge 1 commit intoapache:masterfrom
Conversation
|
I think it is not necessary to rewrite query in superset. Instead, fix it in clickhouse_sqlalchemy. |
9 tasks
Member
|
Superseded by #21195, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


SUMMARY
version : superset 1.5.0
python : 3.8
connect db:clickhouse + http(8123)
if you run any clickhouse sql with "format" keyword, returned results have no column headers,the first row of results will be the column header。
In this case, if the first column has a null value, an error will be thrown directly。
After troubleshooting, the problem lies in the referenced package clickhouse_sqlalchemy/drivers/http/connector.py:112

Therefore, the SQL with format keyword needs to add format parameters “FORMAT TabSeparatedWithNamesAndTypes” manually
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before

after

TESTING INSTRUCTIONS
1、run any clickhouse sql with "format" keyword. like
select subtractDays(toDateTime(formatDateTime(now(),'%Y-%m-%d 00:00:00')),2) as tADDITIONAL INFORMATION
Fixes Python Issue leaks to SQL Lab when querying Clickhouse #19253