Skip to content

Conversation

anlowee
Copy link
Member

@anlowee anlowee commented Jun 9, 2025

Description

This PR is to fix #7 , we should treat release-0.293-clp-connector as our "main" branch. Also we can limit the workflows to run only when directly pushing to release-0.293-clp-connector or the PR's target branch is release-0.293-clp-connector to avoid uncessary workflows run.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Validated the workflows succeeded in my fork.
  • Validated that pushing a change while the workflows were in progress led to them being cancelled and restarted to run against the latest changes.

Summary by CodeRabbit

  • Chores
    • Updated workflow configurations so that in-progress jobs are now only preserved for the release-0.293-clp-connector branch instead of the main branch across all GitHub Actions workflows.
    • Updated related comments to reflect the new branch exclusion.
    • Updated the subproject reference for presto-native-execution/velox.

Copy link

coderabbitai bot commented Jun 9, 2025

Walkthrough

This change updates the concurrency configuration in multiple GitHub Actions workflow files. The branch excluded from in-progress job cancellation is switched from main to release-0.293-clp-connector, ensuring that jobs for this release branch are not cancelled prematurely. No other workflow logic or job definitions are modified.

Changes

Files Change Summary
.github/workflows/arrow-flight-tests.yml, .github/workflows/docs.yml, .github/workflows/hive-tests.yml, .github/workflows/kudu.yml, .github/workflows/maven-checks.yml, .github/workflows/prestocpp-format-and-header-check.yml, .github/workflows/prestocpp-linux-build-and-unit-test.yml, .github/workflows/prestocpp-linux-build.yml, .github/workflows/product-tests-basic-environment.yml, .github/workflows/product-tests-specific-environment.yml, .github/workflows/singlestore-tests.yml, .github/workflows/spark-integration.yml, .github/workflows/test-other-modules.yml, .github/workflows/tests.yml, .github/workflows/web-ui-checks.yml Updated concurrency cancellation exclusion from main to release-0.293-clp-connector branch.
presto-native-execution/velox Updated subproject commit reference.

Assessment against linked issues

Objective Addressed Explanation
Enable workflow-level concurrency groups for efficiency (#7)
Standardize concurrency management across all workflows (#7)
No change to workflow triggers or job definitions as per this PR (#7) Workflow triggers and job definitions were not modified in this PR.
Remove redundant per-job concurrency settings in favour of global workflow-level controls (#7) The PR only updates the branch exclusion; removal of per-job concurrency is not evident here.

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Updated subproject commit reference (presto-native-execution/velox) Changing the Velox submodule reference is unrelated to concurrency configuration objectives.

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb8fd9e and 86ec5aa.

📒 Files selected for processing (16)
  • .github/workflows/arrow-flight-tests.yml (1 hunks)
  • .github/workflows/docs.yml (1 hunks)
  • .github/workflows/hive-tests.yml (1 hunks)
  • .github/workflows/kudu.yml (1 hunks)
  • .github/workflows/maven-checks.yml (1 hunks)
  • .github/workflows/prestocpp-format-and-header-check.yml (1 hunks)
  • .github/workflows/prestocpp-linux-build-and-unit-test.yml (1 hunks)
  • .github/workflows/prestocpp-linux-build.yml (1 hunks)
  • .github/workflows/product-tests-basic-environment.yml (1 hunks)
  • .github/workflows/product-tests-specific-environment.yml (1 hunks)
  • .github/workflows/singlestore-tests.yml (1 hunks)
  • .github/workflows/spark-integration.yml (1 hunks)
  • .github/workflows/test-other-modules.yml (1 hunks)
  • .github/workflows/tests.yml (1 hunks)
  • .github/workflows/web-ui-checks.yml (1 hunks)
  • presto-native-execution/velox (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (19)
  • GitHub Check: product-tests-specific-environment1 (8.0.442)
  • GitHub Check: kudu (8.0.442)
  • GitHub Check: test-other-modules (8.0.442)
  • GitHub Check: singlestore-dockerized-tests (17.0.13)
  • GitHub Check: test (17.0.13, :presto-main-base)
  • GitHub Check: test (17.0.13, :presto-tests -P ci-only-tpch-distributed-queries)
  • GitHub Check: test (8.0.442, :presto-spark-base -P presto-spark-tests-smoke)
  • GitHub Check: test (8.0.442, :presto-accumulo)
  • GitHub Check: test (8.0.442, :presto-tests -P ci-only-local-queries)
  • GitHub Check: test (8.0.442, :presto-tests -P ci-only-tpch-distributed-queries)
  • GitHub Check: test (8.0.442, :presto-tests -P presto-tests-execution-memory)
  • GitHub Check: test (8.0.442, :presto-tests -P ci-only-distributed-non-hash-gen)
  • GitHub Check: prestocpp-linux-build-for-test
  • GitHub Check: arrowflight-java-tests (17.0.13, :presto-base-arrow-flight)
  • GitHub Check: arrowflight-java-tests (8.0.442, :presto-base-arrow-flight)
  • GitHub Check: prestocpp-linux-build-engine
  • GitHub Check: prestocpp-linux-build-for-test
  • GitHub Check: maven-checks (8.0.442)
  • GitHub Check: maven-checks (17.0.13)
🔇 Additional comments (16)
presto-native-execution/velox (1)

1-1: Approve Velox submodule bump.

The Velox subproject commit has been updated to ff37a0821db9b489071bd0b4471efc42aaae9b11. No functional changes here—ensure that all downstream builds and tests against this new pointer have passed.

.github/workflows/prestocpp-linux-build-and-unit-test.yml (1)

17-20: Exclude release branch from cancellation
Correctly updated cancel-in-progress to skip release-0.293-clp-connector, ensuring in-progress jobs on this branch aren’t cancelled.

.github/workflows/product-tests-basic-environment.yml (1)

18-21: Exclude release branch from cancellation
The cancel-in-progress condition is now set to false for refs/heads/release-0.293-clp-connector, preserving in-flight jobs on that branch.

.github/workflows/prestocpp-format-and-header-check.yml (1)

17-20: Exclude release branch from cancellation
The concurrency block correctly omits release-0.293-clp-connector from job cancellation.

.github/workflows/product-tests-specific-environment.yml (1)

18-21: Exclude release branch from cancellation
cancel-in-progress is properly configured to retain in-progress jobs on the release branch.

.github/workflows/prestocpp-linux-build.yml (1)

59-62: Exclude release branch from cancellation
The cancel-in-progress expression accurately targets all branches except release-0.293-clp-connector, preserving its workflow runs.

.github/workflows/tests.yml (1)

19-21: Updated cancellation exclusion to release-0.293-clp-connector.
The concurrency block now correctly retains in-progress jobs only for the release-0.293-clp-connector branch, as intended.

.github/workflows/hive-tests.yml (1)

19-21: Switch concurrency exclusion to release-0.293-clp-connector.
In-progress Hive test runs will now persist for the specified release branch instead of main, which aligns with the PR goal.

.github/workflows/spark-integration.yml (1)

19-21: Adjust concurrency cancel-in-progress for release branch.
The workflow now preserves in-progress Spark integration jobs on the release-0.293-clp-connector branch rather than main.

.github/workflows/test-other-modules.yml (1)

19-21: Exclude release-0.293-clp-connector from job cancellation.
Test-other-modules retains in-progress CI runs on the release branch, per the PR’s update.

.github/workflows/maven-checks.yml (1)

17-19: Change concurrency exclusion to the release branch.
Maven checks now correctly exclude release-0.293-clp-connector from in-progress job cancellation instead of main.

.github/workflows/kudu.yml (1)

18-20: Exclude release-0.293-clp-connector branch from in-progress job cancellation
The cancel-in-progress setting now correctly skips cancellation for the release branch while enforcing it on all others.

.github/workflows/web-ui-checks.yml (1)

15-17: Exclude release-0.293-clp-connector branch from in-progress job cancellation
This update ensures web-UI checks on the release branch aren’t aborted mid-run, matching the intended CI behaviour.

.github/workflows/docs.yml (1)

23-25: Exclude release-0.293-clp-connector branch from in-progress job cancellation
The concurrency rule now properly retains in-flight docs jobs on the release branch and cancels them elsewhere.

.github/workflows/singlestore-tests.yml (1)

19-21: Exclude release-0.293-clp-connector branch from in-progress job cancellation
The cancel-in-progress expression is correctly inverted to safeguard release-branch test runs.

.github/workflows/arrow-flight-tests.yml (1)

22-24: Exclude release-0.293-clp-connector branch from in-progress job cancellation
This change aligns arrow-flight tests’ concurrency logic with the new release branch policy.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anlowee anlowee marked this pull request as ready for review June 9, 2025 14:37
@anlowee anlowee requested a review from kirkrodrigues June 9, 2025 14:38
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

fix: Change GH workflows to treat `release-0.293-clp-connector` (instead of `main`) as the default branch.

@anlowee anlowee changed the title fix: The workflow should treat release-0.293-clp-connector as our "main" branch. fix: Change GH workflows to treat release-0.293-clp-connector (instead of main) as the default branch. Jun 10, 2025
@anlowee anlowee merged commit f7148bd into y-scope:release-0.293-clp-connector Jun 10, 2025
20 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants