Skip to content

ci: Enable all functional GH workflows for pushes and pull requests; Enable workflow-level concurrency groups for efficiency. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 5, 2025
Merged

ci: Enable all functional GH workflows for pushes and pull requests; Enable workflow-level concurrency groups for efficiency. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a472db3
ci: Enable all non-release workflows.
kirkrodrigues Jun 2, 2025
1248b77
Delete unnecessary workflow.
kirkrodrigues Jun 2, 2025
df05df7
Checkout code before running dorny/paths-filter.
kirkrodrigues Jun 2, 2025
3f5d37e
Enable workflow-level concurrency groups to cancel in-progress workfl…
kirkrodrigues Jun 2, 2025
890098b
Disable automatic running of prestocpp-macos-build workflow since it'…
kirkrodrigues Jun 3, 2025
07eb7a4
Change to test workflow cancellation.
kirkrodrigues Jun 3, 2025
fcf9672
Revert "Change to test workflow cancellation."
kirkrodrigues Jun 3, 2025
c88b11e
Remove the release notes check workflow.
kirkrodrigues Jun 3, 2025
659a04a
Remove disabled workflow.
kirkrodrigues Jun 5, 2025
d0d62f3
Fix typo.
kirkrodrigues Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/arrow-flight-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
pull_request:
paths-ignore:
- 'presto-docs/**'
push:
paths-ignore:
- 'presto-docs/**'

env:
CONTINUOUS_INTEGRATION: true
Expand All @@ -13,6 +16,13 @@ env:
MAVEN_TEST: "-B -Dair.check.skip-all -Dmaven.javadoc.skip=true -DLogTestDurationListener.enabled=true --no-transfer-progress --fail-at-end"
RETRY: .github/bin/retry

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
arrowflight-java-tests:
runs-on: ubuntu-latest
Expand All @@ -24,9 +34,6 @@ jobs:
- ":presto-base-arrow-flight" # Only run tests for the `presto-base-arrow-flight` module

timeout-minutes: 80
concurrency:
group: ${{ github.workflow }}-test-${{ matrix.modules }}-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true

steps:
# Checkout the code only if there are changes in the relevant files
Expand Down Expand Up @@ -148,9 +155,6 @@ jobs:
- ":presto-base-arrow-flight" # Only run tests for the `presto-base-arrow-flight` module

timeout-minutes: 80
concurrency:
group: ${{ github.workflow }}-test-${{ matrix.modules }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

steps:
- uses: actions/checkout@v4
Expand Down
23 changes: 0 additions & 23 deletions .github/workflows/codenotify.yml
View file
Open in desktop

This file was deleted.

13 changes: 10 additions & 3 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
pull_request:
paths:
- 'presto-docs/**'
push:
paths:
- 'presto-docs/**'

env:
# An envar that signals to tests we are executing in the CI environment
Expand All @@ -14,6 +17,13 @@ env:
MAVEN_TEST: "-B -Dair.check.skip-all -Dmaven.javadoc.skip=true -DLogTestDurationListener.enabled=true --no-transfer-progress --fail-at-end"
RETRY: .github/bin/retry

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
test:
runs-on: ubuntu-latest
Expand All @@ -23,9 +33,6 @@ jobs:
modules:
- ":presto-docs"
timeout-minutes: 80
concurrency:
group: ${{ github.workflow }}-test-${{ matrix.modules }}-${{ github.event.pull_request.number }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
with:
Expand Down
18 changes: 11 additions & 7 deletions .github/workflows/hive-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: hive tests

on:
pull_request:
push:

env:
# An envar that signals to tests we are executing in the CI environment
Expand All @@ -12,6 +13,13 @@ env:
MAVEN_TEST: "-B -Dair.check.skip-all -Dmaven.javadoc.skip=true -DLogTestDurationListener.enabled=true --no-transfer-progress --fail-at-end"
RETRY: .github/bin/retry

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
changes:
runs-on: ubuntu-latest
Expand All @@ -22,7 +30,9 @@ jobs:
outputs:
codechange: ${{ steps.filter.outputs.codechange }}
steps:
# For pull requests it's not necessary to checkout the code
- uses: "actions/checkout@v4"
with:
submodules: "recursive"
Comment on lines +33 to +35
Copy link

@coderabbitai coderabbitai bot Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix YAML indentation for checkout step
The - uses: actions/checkout@v4 block is indented too far left, causing a YAML parsing error. Please apply this diff to align it under steps::

-    - uses: actions/checkout@v4
-      with:
-        submodules: "recursive"
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: "actions/checkout@v4"
with:
submodules: "recursive"
- uses: actions/checkout@v4
with:
submodules: recursive
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 33-33: wrong indentation: expected 6 but found 4

(indentation)

🤖 Prompt for AI Agents 
In .github/workflows/hive-tests.yml around lines 33 to 35, the `- uses:
actions/checkout@v4` step is incorrectly indented, causing a YAML parsing error.
Adjust the indentation so that this step is properly nested under the `steps:`
key, aligning it with other steps in the workflow to ensure valid YAML
structure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do this, because we are extending the existing github worflows from OSS presto. If you see the L26~L28 the - uses has the same indentation.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anlowee You're absolutely right! I can see that the existing - uses: dorny/paths-filter@v2 step on line 26 follows the same indentation pattern. Maintaining consistency with the OSS Presto workflow formatting makes perfect sense. Thank you for the clarification.

✏️ Learnings added 
Learnt from: anlowee
PR: y-scope/presto#7
File: .github/workflows/hive-tests.yml:33-35
Timestamp: 2025-06-04T14:50:43.523Z
Learning: In the y-scope/presto repository, GitHub workflows are extended from OSS Presto and should maintain consistent formatting with the upstream patterns, including YAML indentation styles for workflow steps.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

- uses: dorny/paths-filter@v2
id: filter
with:
Expand All @@ -38,9 +48,6 @@ jobs:
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-hive-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
if: needs.changes.outputs.codechange == 'true'
Expand Down Expand Up @@ -92,9 +99,6 @@ jobs:
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 20
concurrency:
group: ${{ github.workflow }}-hive-dockerized-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
if: needs.changes.outputs.codechange == 'true'
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/kudu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: kudu

on:
pull_request:
push:

env:
# An envar that signals to tests we are executing in the CI environment
Expand All @@ -11,6 +12,13 @@ env:
MAVEN_FAST_INSTALL: "-B -V --quiet -T 1C -DskipTests -Dair.check.skip-all -Dmaven.javadoc.skip=true"
RETRY: .github/bin/retry

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
changes:
runs-on: ubuntu-latest
Expand All @@ -21,7 +29,9 @@ jobs:
outputs:
codechange: ${{ steps.filter.outputs.codechange }}
steps:
# For pull requests it's not necessary to checkout the code
- uses: "actions/checkout@v4"
with:
submodules: "recursive"
Comment on lines +32 to +34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix indentation for the checkout step
YAMLlint reports incorrect indentation here; the - uses step and its with block should be indented two spaces further under steps:.

Apply this diff:

-    - uses: "actions/checkout@v4"
-      with:
-        submodules: "recursive"
+      - uses: "actions/checkout@v4"
+        with:
+          submodules: "recursive"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: "actions/checkout@v4"
with:
submodules: "recursive"
- uses: "actions/checkout@v4"
with:
submodules: "recursive"
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 32-32: wrong indentation: expected 6 but found 4

(indentation)

🤖 Prompt for AI Agents 
In .github/workflows/kudu.yml around lines 32 to 34, the checkout step is
incorrectly indented under the steps section. Increase the indentation of the `-
uses: "actions/checkout@v4"` line and its nested `with:` block by two spaces so
they are properly nested under the `steps:` key, ensuring valid YAML structure
and passing YAMLlint checks.

- uses: dorny/paths-filter@v2
id: filter
with:
Expand All @@ -36,9 +46,6 @@ jobs:
runs-on: ubuntu-latest
needs: changes
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-kudu-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
if: needs.changes.outputs.codechange == 'true'
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/maven-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: maven checks

on:
pull_request:
push:

env:
# An envar that signals to tests we are executing in the CI environment
Expand All @@ -10,6 +11,13 @@ env:
MAVEN_INSTALL_OPTS: "-Xmx2G -XX:+ExitOnOutOfMemoryError"
RETRY: .github/bin/retry

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
maven-checks:
strategy:
Expand All @@ -18,9 +26,6 @@ jobs:
java: [ 8.0.442, 17.0.13 ]
runs-on: ubuntu-latest
timeout-minutes: 45
concurrency:
group: ${{ github.workflow }}-maven-checks-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
run: |
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/prestocpp-format-and-header-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ on:
paths:
- 'presto-native-execution/**'
- '.github/workflows/prestocpp-format-and-header-check.yml'
push:
paths:
- 'presto-native-execution/**'
- '.github/workflows/prestocpp-format-and-header-check.yml'

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
prestocpp-format-and-header-check:
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/prestocpp-linux-build-and-unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,16 @@ on:
- 'presto-native-sidecar-plugin/**'
- '.github/workflows/prestocpp-linux-build-and-unit-test.yml'
push:
branches:
- master
paths-ignore:
- 'presto-docs/**'

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
prestocpp-linux-build-for-test:
runs-on: ubuntu-22.04
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/prestocpp-linux-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,38 @@ on:
- 'presto-iceberg/src/main/java/com/facebook/presto/iceberg/**'
# tpch
- 'presto-tpch/src/main/java/com/facebook/presto/tpch/**'
push:
paths:
- 'presto-native-execution/**'
- '.github/workflows/prestocpp-linux-build.yml'
# Build also changes to files that can change the protocol and are referenced in the protocol yaml:
# protocol_core
- 'presto-spi/src/main/java/com/facebook/presto/spi/**'
- 'presto-common/src/main/java/com/facebook/presto/**'
- 'presto-main/src/main/java/com/facebook/presto/**'
- 'presto-client/src/main/java/com/facebook/presto/client/**'
- 'presto-spark-base/src/main/java/com/facebook/presto/spark/execution/**'
- 'presto-native-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/nativechecker/**'
- 'presto-function-namespace-managers-common/src/main/java/com/facebook/presto/functionNamespace/**'
- 'presto-hdfs-core/src/main/java/com/facebook/presto/hive/**'
- 'presto-verifier/src/main/java/com/facebook/presto/verifier/framework/**'
# arrow-flight
- 'presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/**'
# hive
- 'presto-hive-metastore/src/main/java/com/facebook/presto/hive/**'
- 'presto-hive-common/src/main/java/com/facebook/presto/hive/**'
- 'presto-hive/src/main/java/com/facebook/presto/hive/**'
# iceberg
- 'presto-iceberg/src/main/java/com/facebook/presto/iceberg/**'
# tpch
- 'presto-tpch/src/main/java/com/facebook/presto/tpch/**'

concurrency:
group: "${{github.workflow}}-${{github.ref}}"

# Cancel in-progress jobs for efficiency. Exclude the `main` branch so that each commit to main is
# checked completely.
cancel-in-progress: "${{github.ref != 'refs/heads/main'}}"

jobs:
prestocpp-linux-build-engine:
Expand Down
74 changes: 0 additions & 74 deletions .github/workflows/prestocpp-macos-build.yml
View file
Open in desktop

This file was deleted.

Loading
Loading