Skip to content

build: Ignore clang's implicit-const-int-float-conversion warning since the existing Velox code contains violations. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 20, 2025
Merged

build: Ignore clang's implicit-const-int-float-conversion warning since the existing Velox code contains violations. #12

Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
17a3ee4
misc: Use pre-commit for quality checks (#13361)
assignUser Jun 10, 2025
40afa57
Fix pre-commit check
Jun 18, 2025
e972b81
Add DIY cache management
Jun 18, 2025
f7a5f79
Fix
Jun 18, 2025
7ee96d9
Remove the DIY cache manage ment for prelimiary check because it is n…
Jun 18, 2025
b9f5816
Add full path
Jun 18, 2025
13c0794
Fix precommit check and use minimal build to test
Jun 18, 2025
3f445dd
Fix the path
Jun 18, 2025
04c6191
Fix
Jun 18, 2025
8df7c10
Fix
Jun 18, 2025
f430fd6
Test ccache
Jun 18, 2025
a8d72a0
Fix
Jun 18, 2025
0659d3e
Use ccache
Jun 18, 2025
a1ae373
exp
Jun 18, 2025
49ee963
Fix
Jun 18, 2025
175e131
Test finished
Jun 18, 2025
16e8eaf
Fix
Jun 18, 2025
d99245f
Apply comments
Jun 19, 2025
8d95db1
Fix
Jun 19, 2025
65fc6b2
Fix clang
Jun 19, 2025
ad575dc
Revert test
Jun 19, 2025
3d125f3
Merge branch 'presto-0.293-clp-connector' into xwei/fix-clang
anlowee Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,8 @@ endif()
if(ENABLE_ALL_WARNINGS)
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
set(KNOWN_COMPILER_SPECIFIC_WARNINGS
"-Wno-range-loop-analysis \
"-Wno-implicit-const-int-float-conversion \
-Wno-range-loop-analysis \
-Wno-mismatched-tags \
-Wno-nullability-completeness")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
Expand Down