Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/socket middleware #269

Merged
merged 16 commits into from
Aug 8, 2024
Merged

Feat/socket middleware #269

merged 16 commits into from
Aug 8, 2024

Conversation

gvozdenkov
Copy link
Contributor

No description provided.

@gvozdenkov gvozdenkov requested a review from INextYP July 29, 2024 06:16
@gvozdenkov gvozdenkov linked an issue Jul 29, 2024 that may be closed by this pull request
Реализация системной мидвары для подключения к Socket.io #254
Closed
6 tasks
@gvozdenkov gvozdenkov mentioned this pull request Jul 29, 2024
Closed
6 tasks
kspshnik
kspshnik requested changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@kspshnik kspshnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почти всё готово :)
Чуть-чуть архитектуру в нужную сторону повернуть - и порядок!

src/app/store/index.ts Outdated Show resolved Hide resolved
src/entities/chat/model/socket.ts Outdated Show resolved Hide resolved
src/services/websocket-middleware.ts Show resolved Hide resolved
INextYP
INextYP requested changes Jul 29, 2024
View reviewed changes
src/services/websocket-middleware.ts Outdated Show resolved Hide resolved
@IvannaBalanyuk
Copy link
Contributor

@INextYP @kspshnik

  • прошлась по замечаниям, вроде бы всё поправила;
  • добавила старт ws-подключения для реципиента (в ProfileActivePage);
  • добавила инициацию закрытия ws-подключения в случае выхода юзера (в DropDownMenu).

@IvannaBalanyuk IvannaBalanyuk self-assigned this Aug 5, 2024
@kspshnik kspshnik added the feature New feature label Aug 8, 2024
kspshnik
kspshnik previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@kspshnik kspshnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отлично, начало положено!!

INextYP
INextYP approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@INextYP INextYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё отлично! :)

@INextYP INextYP merged commit 7e4a347 into develop Aug 8, 2024
@INextYP INextYP deleted the feat/socket-middleware branch August 8, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvannaBalanyuk IvannaBalanyuk IvannaBalanyuk left review comments

@INextYP INextYP INextYP approved these changes

@kspshnik kspshnik kspshnik left review comments

Assignees

@IvannaBalanyuk IvannaBalanyuk

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Реализация системной мидвары для подключения к Socket.io
4 participants
@gvozdenkov @IvannaBalanyuk @kspshnik @INextYP