QTL Integration Style Tests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyluoex
force-pushed
the
QTLEndToEndTesting
branch
2 times, most recently
from
f468ce2
to
a1ee775
Compare
| @@ -837,7 +837,7 @@ protected ConfigurationLoader buildConfigurationLoader( | |||
| * @return a Dimension Loader instance | |||
| */ | |||
| protected DimensionLoader getDimensionLoader() { | |||
| return new KeyValueStoreDimensionLoader(getDimensionConfigurations()); | |||
| return new TypeAwareDimensionLoader(getDimensionConfigurations()); | |||
There was a problem hiding this comment.
Need to call out this change in Changelog
garyluoex
force-pushed
the
QTLEndToEndTesting
branch
from
853c515
to
cac8388
Compare
| LogicalTable petsTable = petsShapesTables.find {it.getName() == "pets"} | ||
|
|
||
| when: | ||
| TableGrainView tableGrainView = fullViewProcessor.formatTableGrain(petsTable, "all", uriInfo) | ||
|
|
||
| then: | ||
| tableGrainView.toString() == expectedResponse | ||
| tableGrainView.sort().toString() == expectedResponse |
There was a problem hiding this comment.
Why are we sorting here? What changed that we need to sort now but didn't before?
There was a problem hiding this comment.
Instead of containing KeyValueStoreDimension, the table now contains LookupDimension which changed the order of the dimensions. I can look into it if you think it is necessary and remove the sort?
|
👍 after those 2 small comments |
garyluoex
force-pushed
the
QTLEndToEndTesting
branch
from
7cfb4ea
to
ac4c349
Compare
|
👍 |
cdeszaq
force-pushed
the
QTLEndToEndTesting
branch
from
ac4c349
to
d69711a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LookupDimensionFilteringDataServeletSpecandLookupDimensionGroupingDataServletSpecto test QTL functionalityLookupDimensions