-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QTL Integration Style Tests #34
Conversation
f468ce2
to
a1ee775
Compare
@@ -837,7 +837,7 @@ protected ConfigurationLoader buildConfigurationLoader( | |||
* @return a Dimension Loader instance | |||
*/ | |||
protected DimensionLoader getDimensionLoader() { | |||
return new KeyValueStoreDimensionLoader(getDimensionConfigurations()); | |||
return new TypeAwareDimensionLoader(getDimensionConfigurations()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to call out this change in Changelog
853c515
to
cac8388
Compare
LogicalTable petsTable = petsShapesTables.find {it.getName() == "pets"} | ||
|
||
when: | ||
TableGrainView tableGrainView = fullViewProcessor.formatTableGrain(petsTable, "all", uriInfo) | ||
|
||
then: | ||
tableGrainView.toString() == expectedResponse | ||
tableGrainView.sort().toString() == expectedResponse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we sorting here? What changed that we need to sort now but didn't before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of containing KeyValueStoreDimension
, the table now contains LookupDimension
which changed the order of the dimensions. I can look into it if you think it is necessary and remove the sort?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it's probably fine.
👍 after those 2 small comments |
7cfb4ea
to
ac4c349
Compare
👍 |
ac4c349
to
d69711a
Compare
LookupDimensionFilteringDataServeletSpec
andLookupDimensionGroupingDataServletSpec
to test QTL functionalityLookupDimension
s