Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTL Integration Style Tests #34

Merged
merged 1 commit into from
Sep 12, 2016
Merged

QTL Integration Style Tests #34

merged 1 commit into from
Sep 12, 2016

Conversation

garyluoex
Copy link
Collaborator

@garyluoex garyluoex commented Sep 2, 2016

  • Added two tests LookupDimensionFilteringDataServeletSpec and LookupDimensionGroupingDataServletSpec to test QTL functionality
  • Modified some testing resources (PETS table and corresponding dimensions) to allow better testing on LookupDimensions

@garyluoex garyluoex added the WIP label Sep 2, 2016
@garyluoex garyluoex force-pushed the QTLEndToEndTesting branch 2 times, most recently from f468ce2 to a1ee775 Compare September 2, 2016 18:12
@@ -837,7 +837,7 @@ protected ConfigurationLoader buildConfigurationLoader(
* @return a Dimension Loader instance
*/
protected DimensionLoader getDimensionLoader() {
return new KeyValueStoreDimensionLoader(getDimensionConfigurations());
return new TypeAwareDimensionLoader(getDimensionConfigurations());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to call out this change in Changelog

LogicalTable petsTable = petsShapesTables.find {it.getName() == "pets"}

when:
TableGrainView tableGrainView = fullViewProcessor.formatTableGrain(petsTable, "all", uriInfo)

then:
tableGrainView.toString() == expectedResponse
tableGrainView.sort().toString() == expectedResponse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we sorting here? What changed that we need to sort now but didn't before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of containing KeyValueStoreDimension, the table now contains LookupDimension which changed the order of the dimensions. I can look into it if you think it is necessary and remove the sort?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it's probably fine.

@cdeszaq
Copy link
Collaborator

cdeszaq commented Sep 8, 2016

👍 after those 2 small comments

@prakashnm
Copy link

👍

@cdeszaq cdeszaq merged commit d69711a into master Sep 12, 2016
@cdeszaq cdeszaq deleted the QTLEndToEndTesting branch September 12, 2016 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants