Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: update generated app dependencies #690

Merged

Conversation

pablopalacios
Copy link
Contributor

  • Removed unused dependencies
  • Removed eslint and editorconfig (in favor of BYO)
  • Implemented the same tooling as in examples/minimal

I tested locally by running npm link and then yo fluxible. After that I was able to run the application in dev and in prod mode successfully.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Contributor

@redonkulus redonkulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks again for your effort!

@redonkulus redonkulus merged commit d03a10e into yahoo:fluxible-addons-react-1.x-dev May 12, 2021
@pablopalacios pablopalacios deleted the generator branch May 13, 2021 09:18
pablopalacios added a commit to pablopalacios/fluxible that referenced this pull request Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants