Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdom@10.1.0 breaks build 🚨 #159

Merged
merged 1 commit into from
May 3, 2017
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

🚨🔥⚠️ Action required: Switch to the new Greenkeeper now! 🚨🔥⚠️
This version of Greenkeper will be shutdown on May 31st.
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.


Hello lovely humans,

jsdom just published its new version 10.1.0.

State Failing tests 🚨
Dependency jsdom
New version 10.1.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As jsdom is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 15 commits .

  • d078830 Version 10.1.0
  • e3e4629 Enable FormData being iterable
  • 8d3f747 Implement HTMLSelectElement's selectedOptions
  • e79e9a1 Fix xhr.abort() during XHR readystatechange
  • 270f288 Pre-allocate XMLHttpRequest buffer
  • 2552a85 Disable flaky XHR tests
  • 8c1709b Clear the "generated" directory each run
  • ca8dfef Ensure { runScripts: "outside-only" } also passes down to iframes
  • 3d0f28d Properly inherit "document features" configuration into iframes
  • 1f488ec Remove stray toString directly on Window
  • 9d0c03e Use Symbol.toStringTag to make Object.prototype.toString work
  • 4591c3c Fix TODO links to the paper about jsdom in a web worker
  • ac49743 Implement value sanitization algorithms for several input types
  • b2bfc3d Add an issue template
  • aea99cd Document fix to img load events in the v10 changelog

See the full diff.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.677% when pulling 67a6bb5 on greenkeeper-jsdom-10.1.0 into ecce2cb on master.

@redonkulus redonkulus merged commit 2acf51d into master May 3, 2017
@redonkulus redonkulus deleted the greenkeeper-jsdom-10.1.0 branch May 3, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants