Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
jsdom just published its new version 10.1.0.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As jsdom is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 15 commits .
d078830
Version 10.1.0
e3e4629
Enable FormData being iterable
8d3f747
Implement HTMLSelectElement's selectedOptions
e79e9a1
Fix xhr.abort() during XHR readystatechange
270f288
Pre-allocate XMLHttpRequest buffer
2552a85
Disable flaky XHR tests
8c1709b
Clear the "generated" directory each run
ca8dfef
Ensure { runScripts: "outside-only" } also passes down to iframes
3d0f28d
Properly inherit "document features" configuration into iframes
1f488ec
Remove stray toString directly on Window
9d0c03e
Use Symbol.toStringTag to make Object.prototype.toString work
4591c3c
Fix TODO links to the paper about jsdom in a web worker
ac49743
Implement value sanitization algorithms for several input types
b2bfc3d
Add an issue template
aea99cd
Document fix to img load events in the v10 changelog
See the full diff.