Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userlog route updates: speed #202

Closed
yakra opened this issue Feb 20, 2022 · 2 comments · Fixed by TravelMapping/DataProcessing#502
Closed

userlog route updates: speed #202

yakra opened this issue Feb 20, 2022 · 2 comments · Fixed by TravelMapping/DataProcessing#502

Comments

@yakra
Copy link
Owner

yakra commented Feb 20, 2022

Will changing routes.insert(r).second && r->last_update to r->last_update && routes.insert(r).second etc. yield a noticeable speed increase?

@yakra
Copy link
Owner Author

yakra commented Feb 26, 2022

Nope. Failing to insert the route into the set results in missing "long list" entries @ end of log file.

@yakra yakra closed this as completed Feb 26, 2022
@yakra
Copy link
Owner Author

yakra commented Feb 26, 2022

Yep! The insertions didn't take place because:
The one line changed was the one in Route.cpp, and the insertion was put after the update time comparison.
If only the two args mentioned in the OP are swapped, we're fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant