Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update notification bugfixes (#500) / speedup #502

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

yakra
Copy link
Contributor

@yakra yakra commented Feb 27, 2022

  • Closes formerly connected routes #500
    • Fixes Python bug where entries for the first chopped route in a ConnectedRoute would prevent update notifications for the last chopped route for "not in same connected route" errors.
    • Always show updates for broken entries; avoid having good entries updated before the .list file prevent them
  • Closes userlog route updates: speed yakra/DataProcessing#202
    • C++ is about 2% faster Processing traveler list files.
    • Python is faster only in theory, not noticeably so in practice. Within margin of error.

interactive rebase 812780cbc18bb42539256664d8fafd7d6182fa86
@jteresco
Copy link
Contributor

In for the next update.

@yakra
Copy link
Contributor Author

yakra commented Apr 13, 2022

List502
I didn't initially include a chart, because the old<->new speeds for each machine are so tiny. Barely any visible distance. LOL that's a typo. Visible difference.

Dropping this here now because it shows how the different machines stack up against one another, and more importantly, it's one more task for which I have FreeBSD data ready to go.

Normally, the caption up top would list the HighwayData & UserData commits used in the speed tests, but they were erroneously recorded as the DataProcessing commits seen in the legend on the right instead. So I just removed that info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formerly connected routes userlog route updates: speed
2 participants