This repository was archived by the owner on May 12, 2020. It is now read-only.
Refactoring, fixes for 80, 81 #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qatools-ci
reviewed
May 11, 2017
| } | ||
|
|
||
| if (all.baseDirIsGenerated()) { | ||
| if (!deleteQuietly(all.baseDir())) { |
There was a problem hiding this comment.
Merge this if statement with the enclosing one. 
Playing around shutdown feedback (fixes yandex-qatools#80). Trying to indicate 2 patterns for executable (refs yandex-qatools#81).
|
SonarQube analysis reported 1 issue:
Watch the comments in this conversation to review them. |
This was referenced May 12, 2017
BorzdeG
reviewed
Jul 19, 2017
| @@ -18,6 +18,9 @@ | |||
| public void testDownloads() throws IOException { | |||
| IArtifactStore artifactStore = new PostgresArtifactStoreBuilder().defaults(Command.Postgres).build(); | |||
|
|
|||
| if(true){ | |||
There was a problem hiding this comment.
Yup. OMG. This is temporary. Rule is "Don't commit after 12pm:)"
There was a problem hiding this comment.
Use the @ignore annotation from JUnit - so in the logs you will see the disabled tests
There was a problem hiding this comment.
There was a problem hiding this comment.
@BorzdeG I know about it, don't worry :).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.