This repository was archived by the owner on May 12, 2020. It is now read-only.
fixed issue #90: separated the unpacked programs for versions #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smecsia
suggested changes
Jul 18, 2017
|
|
||
| public class TestMultipleInstance { | ||
| @Test | ||
| public void testRunTwoConsistentlyInstanceDifferenceVersions() throws Exception { |
There was a problem hiding this comment.
"test" prefix in the method name is actually redundant. Let's call them in accordance with the check, which they perform (e.g. "itShouldAllowToRunTwoInstancesWithDifferentVersions")
| public void testRunTwoConsistentlyInstanceDifferenceVersions() throws Exception { | ||
| final EmbeddedPostgres postgres0 = new EmbeddedPostgres(); | ||
| postgres0.start(); | ||
| Assert.assertTrue(postgres0.getConnectionUrl().isPresent()); |
There was a problem hiding this comment.
Let's use hamcrest matchers here, as they give much more detailed feedback.
| "pgsql" + "-" + distribution.getVersion().asInDownloadPath(), "bin"); | ||
| if (dir.exists() | ||
| && dir.isDirectory() | ||
| && filesSet.entries().stream().allMatch(entry -> exists(path)) |
There was a problem hiding this comment.
Now I can see that this condition was created incorrectly. In fact it is redundant and can be safely replaced with exists(path).
smecsia
pushed a commit
to smecsia/postgresql-embedded
that referenced
this pull request
Jul 21, 2017
…rsions (yandex-qatools#92) * fixed issue yandex-qatools#90: separated the unpacked programs for versions * issue yandex-qatools#41: 0) change tests naming strategy * issue yandex-qatools#41: 0) change tests - using hamcrest matchers * issue yandex-qatools#41: 0) Removed redundant check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.