-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize #34
Dockerize #34
Conversation
Dockerfile
Outdated
|
||
RUN python setup.py install | ||
|
||
ENTRYPOINT ["gixy"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
If you add a .editorconfig to the root of the project, those kind of conventions can be automatically applied by the editor. 👍
Are you going to host it in docker hub? |
I am hosting my fork (https://hub.docker.com/r/nevon/gixy/builds/), just to test it out, but I would rather someone who has contributor status to this repository would host this in the docker hub, since I don't think I can set it up to automatically build on pushes to a repo that I don't own. |
Why using of alpine base image is better than |
Honestly, it just didn't occur to me to search for a python image. When is searched for python alpine, I just found an image by some random guy, so instead I took a base alpine image and installed the distro's version of python. I can rebase this image on top of python:2.7-alpine. |
Thanks!
|
|
Thanks! |
Is it possible to get a couple of lines of docs for how to use the Docker image to test a configuration? |
You just mount the configuration as a volume in the gixy container and give it the path to the config file as an argument. For example:
In my case, I'm already using docker-compose in my CI pipeline, and in that case you can use
Then just |
I think it would be nice to put previous comment into readme.md. Otherwise users have to search for an image on dockerhub, or look for an issue in this repo. |
You're right. |
I'm using this as part of my CI run, which relies heavily on Docker.
You can easily set up an automated build on Docker Cloud to automatically build and push new images by tagging commits.