Defer initial report #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If adding several metrics at once, on the same interval, only the first will be reported in the initial report due to the immediate call to `reporter._reportMetricsWithInterval(...)`. By wrapping that in a `setImmediate(...)`, any other metrics set in that tick should now also be included in the initial report.
Pull Request Test Coverage Report for Build 344
💛 - Coveralls |
fieldju
approved these changes
Dec 18, 2018
|
What do I need to do? |
|
Just use the GitHub release page to do a release. Copy the format from one
of the previous releases. Make sure to bump the minor version in your
release.
If this isn't making sense I can get you screen shots after lunch
Cheers,
Justin
On Tue, Dec 18, 2018 at 12:29 PM Stephen Belanger ***@***.***> wrote:
What do I need to do?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArcLpI5iB0IJ93uVnBBxPO1dfvpprdMks5u6VAwgaJpZM4ZY-Lx>
.
--
Justin Field
fieldju@gmail.com
LinkedIn <https://www.linkedin.com/in/fieldju> | @fieldju
|
|
Ah, yep, I can do that. The package publish itself all happens automatically though, when the PR lands in master, right? |
|
Yeah
On Tue, Dec 18, 2018 at 12:49 PM Stephen Belanger ***@***.***> wrote:
Ah, yep, I can do that. The package publish itself all happens
automatically though, when the PR lands in master, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArcLgtkf4sXGzwqiK0eNpI26lFuqQBIks5u6VTagaJpZM4ZY-Lx>
.
--
Justin Field
fieldju@gmail.com
LinkedIn <https://www.linkedin.com/in/fieldju> | @fieldju
|
|
Should this be minor or patch? Seems more like bug-fix territory to me. 🤔 |
|
I'm ok with either
On Tue, Dec 18, 2018 at 1:02 PM Stephen Belanger ***@***.***> wrote:
Should this be minor or patch? Seems more like bug-fix territory to me. 🤔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArcLpneTWo6TDtNZH-38AhwkErNYAiuks5u6VfbgaJpZM4ZY-Lx>
.
--
Justin Field
fieldju@gmail.com
LinkedIn <https://www.linkedin.com/in/fieldju> | @fieldju
|
|
Sorry, not super clear on how all the release automation stuff fits together... What actually triggers the |
|
Yes, tags get created from the GitHub release dashboard. 👇 Below is an example |
|
|
|
BTW the automation integration with Lerna is a little weird, don't be alarmed when travis runs the tag build 2x, it will just release to NPM once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If adding several metrics at once, on the same interval, only the first will be reported in the initial report due to the immediate call to
reporter._reportMetricsWithInterval(...). By wrapping that in asetImmediate(...), any other metrics set in that tick should now also be included in the initial report.