Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added QFT benchmark for Qulacs #30

Closed
wants to merge 4 commits into from
Closed

Added QFT benchmark for Qulacs #30

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2021

  • Added QFT benchmark for Qulacs

Note: Could not find the CRZ equivalent in Qulacs. Used the decomposition in https://pennylane.readthedocs.io/en/stable/code/api/pennylane.CRZ.html Unsure if I've used the correct unitary.

@ghost
Copy link
Author

ghost commented Jan 13, 2021 

---------------------------------------------------------------------------------------------------- benchmark 'QFT': 22 tests -----------------------------------------------------------------------[9/52] ------------------------
Name (time in us)                 Min                        Max                       Mean                 StdDev                     Median                    IQR            Outliers           OPS Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_QFT[4]                    1.8431 (1.0)              21.9103 (1.0)               2.1130 (1.0)           0.2726 (1.0)               2.1006 (1.0)           0.0400 (1.0)       204;838  473,251.5937 (1.0) 36754           1
test_QFT[5]                    3.1390 (1.70)             60.4121 (2.76)              3.4904 (1.65)          0.3889 (1.43)              3.4743 (1.65)          0.0414 (1.03)     300;2002  286,496.3034 (0.6)      88953           1
test_QFT[6]                    6.2361 (3.38)             59.3709 (2.71)              6.4951 (3.07)          0.5659 (2.08)              6.4559 (3.07)          0.0941 (2.35)    1106;1310  153,962.7787 (0.3)      99666           1
test_QFT[7]                   12.8290 (6.96)             44.8269 (2.05)             13.2493 (6.27)          0.8984 (3.30)             13.1740 (6.27)          0.0871 (2.17)     765;2806   75,475.7530 (0.1)      48740           1
test_QFT[8]                   28.0710 (15.23)           129.2937 (5.90)             28.8776 (13.67)         1.5134 (5.55)             28.7462 (13.68)         0.1229 (3.07)     627;4155   34,628.8813 (0.0)      30511           1
test_QFT[9]                   65.6918 (35.64)           139.5219 (6.37)             68.1809 (32.27)         4.1390 (15.18)            67.2447 (32.01)         0.2300 (5.74)    1203;3111   14,666.8583 (0.0)      14122           1
test_QFT[10]                 153.2002 (83.12)           257.7840 (11.77)           159.1916 (75.34)         6.5253 (23.93)           156.9842 (74.73)         0.6293 (15.72)    930;1945    6,281.7385 (0.0)       6241           1
test_QFT[11]                 364.2086 (197.61)          457.0801 (20.86)           377.5187 (178.66)        8.7150 (31.97)           373.6559 (177.88)       10.0670 (251.38)     441;76    2,648.8757 (0.0)       2653           1
test_QFT[12]                 857.1357 (465.05)          957.2427 (43.69)           881.7777 (417.30)       11.7191 (42.98)           877.4959 (417.74)        8.6967 (217.16)    277;169    1,134.0727 (0.0)       1111           1
test_QFT[13]               1,197.9113 (649.95)        2,736.5861 (124.90)        1,326.0671 (627.56)      206.7724 (758.41)        1,259.4713 (599.58)       61.8892 (>1000.0)     16;30      754.1097 (0.0)        182           1
test_QFT[14]               1,886.4661 (>1000.0)       3,357.8654 (153.26)        2,010.2680 (951.36)      169.7104 (622.48)        1,943.7340 (925.32)       76.1235 (>1000.0)     69;81      497.4461 (0.0)        504           1
test_QFT[15]               3,447.2891 (>1000.0)       4,910.2744 (224.11)        3,592.7838 (>1000.0)     205.7847 (754.79)        3,507.4053 (>1000.0)     132.0099 (>1000.0)     31;29      278.3357 (0.00)        276           1
test_QFT[16]               6,844.3581 (>1000.0)       8,078.1691 (368.69)        7,079.0048 (>1000.0)     281.0368 (>1000.0)       6,933.3464 (>1000.0)     265.6828 (>1000.0)     23;12      141.2628 (0.00)        144           1
test_QFT[17]              14,344.8869 (>1000.0)      15,903.0519 (725.83)       14,667.8030 (>1000.0)     356.3350 (>1000.0)      14,497.1563 (>1000.0)     446.5063 (>1000.0)      12;4       68.1765 (0.00)         70           1
test_QFT[18]              32,153.0183 (>1000.0)      35,397.6530 (>1000.0)      33,665.3955 (>1000.0)     912.7876 (>1000.0)      33,573.7271 (>1000.0)   1,010.3558 (>1000.0)      13;0       29.7041 (0.00)         31           1
test_QFT[19]              77,329.3460 (>1000.0)      84,438.6290 (>1000.0)      79,595.6053 (>1000.0)   1,836.1832 (>1000.0)      79,370.6030 (>1000.0)   1,676.6614 (>1000.0)       4;1       12.5635 (0.00)         13           1
test_QFT[20]             172,477.3631 (>1000.0)     179,678.1528 (>1000.0)     175,180.2204 (>1000.0)   2,548.9819 (>1000.0)     174,589.3131 (>1000.0)   2,727.1677 (>1000.0)       2;0        5.7084 (0.00)          6           1
test_QFT[21]             422,536.2251 (>1000.0)     433,188.3271 (>1000.0)     429,623.2116 (>1000.0)   4,402.7011 (>1000.0)     431,185.9822 (>1000.0)   6,056.8714 (>1000.0)       1;0        2.3276 (0.00)          5           1
test_QFT[22]           1,211,414.9090 (>1000.0)   1,231,130.8361 (>1000.0)   1,221,913.3515 (>1000.0)   8,306.9547 (>1000.0)   1,222,764.7183 (>1000.0)  14,417.3307 (>1000.0)       2;0        0.8184 (0.00)          5           1
test_QFT[23]           3,091,829.3688 (>1000.0)   3,118,838.6641 (>1000.0)   3,109,615.8171 (>1000.0)  10,664.0532 (>1000.0)   3,111,306.9030 (>1000.0)  12,263.0598 (>1000.0)       1;0        0.3216 (0.00)          5           1
test_QFT[24]           7,136,340.0919 (>1000.0)   7,242,959.2661 (>1000.0)   7,202,176.1446 (>1000.0)  41,325.9987 (>1000.0)   7,209,134.4399 (>1000.0)  53,098.6077 (>1000.0)       1;0        0.1388 (0.00)          5           1

Roger-luo
Roger-luo reviewed Jan 22, 2021
View reviewed changes
qulacs/benchmarks.py
circuit.add_dense_matrix_gate(wire, [[1,0],[0, np.exp(1j * (np.pi/(2**(wire-i)))/2)]])
circuit.add_CNOT_gate(i, wire)
circuit.add_dense_matrix_gate(wire, [[1,0],[0, np.exp(-1j * (np.pi/(2**(wire-i)))/2)]])
circuit.add_CNOT_gate(i, wire)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's called CUz gate for control shift.

https://github.com/qulacs/qulacs/blob/ed593b832c512cd8aec4b1b6f9dba7e3126e4895/src/csim_old/update_ops_qft.c#L51

Copy link
Author

@ghost ghost Jan 22, 2021 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at the docs and only see a CZ gate and no CUz gate.

http://docs.qulacs.org/en/latest/pyRef/modules.html#qulacs.gate.CZ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK could you file an issue for them then? ask about the best way to implement QFT using their software? also remember to ref this PR.

@Roger-luo Roger-luo mentioned this pull request Feb 4, 2021
Open
@ghost ghost mentioned this pull request Feb 14, 2021
Open
@ghost ghost closed this by deleting the head repository Dec 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roger-luo @saravsak