Draft: Refactor github and tarball fetching and resolution. #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etcher` deprecate github url handling in `plugin-git` add hook: `addHandledHostRepository` to exclude a pattern from being handled by `plugin-git` remove special handling for github urls within `gitUtils.normalizeRepoUrl` It will be handled right in `plugin-github` when `GithubFetcher` is called. update test for `plugin-git` update `GithubFetcher` to offload fetching to `plugin-http` add `GithubResolver` resolves http(s) github urls to tarball urls that are handled by `plugin-http` update test in `plugin-github` update `githubUtils` to support conversion of valid github http urls into tarball urls deprecated providing a `fetchHostedRepository` hook in `plugin-github` change `plugin-github` provides the hook `addHandledHostedRepository` change `plugin-github` provides `GithubFetcher` and `GithubResolver`
|
This approach doesn't work. It actually was similar to this in the past (the GitHub fetcher was a regular resolver/fetcher pair), but we need the hosted git urls to fallback to the classic clone if the url isn't reachable for some reason. |
|
That's quite understandable. I still feel like most of the changes here are for the better. |
calbearox
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add source and workspace option to http urls fetched by
TarballHttpFetcherdeprecate github url handling in
plugin-gitadd hook:
addHandledHostRepositoryto exclude a pattern from being handled byplugin-gitremove special handling for github urls within
gitUtils.normalizeRepoUrlIt will be handled right inplugin-githubwhenGithubFetcheris called.update test for
plugin-gitupdate
GithubFetcherto offload fetching toplugin-httpadd
GithubResolverresolves http(s) github urls to tarball urls that are handled byplugin-httpupdate test in
plugin-githubupdate
githubUtilsto support conversion of valid github http urls into tarball urlsdeprecated providing a
fetchHostedRepositoryhook inplugin-githubchange
plugin-githubprovides the hookaddHandledHostedRepositorychange
plugin-githubprovidesGithubFetcherandGithubResolverWhat's the problem this PR addresses?
...
How did you fix it?
...
Checklist