build(compat): fix building TypeScript patches #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
arcanis
pushed a commit
that referenced
this pull request
Apr 10, 2024
**What's the problem this PR addresses?** Building the latest TypeScript patch requires fetching https://github.com/arcanis/typescript, https://github.com/microsoft/typescript, and https://github.com/merceyz/typescript which, according to git, requires fetching 1.87 GiB, 452 MiB, and 42 MiB of data and produces a 2.7GB `.git` folder. **How did you fix it?** Fork TypeScript to https://github.com/yarnpkg/TypeScript and push the branches required to build all the patches to it and change the script to use a treeless clone of it which only needs to fetch 55 MiB of data and produces a 74MB `.git` folder. Depends on - #6186 **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
added a commit
that referenced
this pull request
May 2, 2024
**What's the problem this PR addresses?** Depending on the version of Node.js and npm you have available; building the TypeScript patches might not work. **How did you fix it?** - Since "recent" versions of TypeScript have a Volta config specifying the Node.js and npm versions to use, change the script to always use Volta to run `node` and `npm`. - For older versions without a complete Volta config I've added one. - Install using `npm ci` when a lockfile is present as using `npm install` causes some TypeScript builds to fail. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
added a commit
that referenced
this pull request
May 2, 2024
**What's the problem this PR addresses?** Building the latest TypeScript patch requires fetching https://github.com/arcanis/typescript, https://github.com/microsoft/typescript, and https://github.com/merceyz/typescript which, according to git, requires fetching 1.87 GiB, 452 MiB, and 42 MiB of data and produces a 2.7GB `.git` folder. **How did you fix it?** Fork TypeScript to https://github.com/yarnpkg/TypeScript and push the branches required to build all the patches to it and change the script to use a treeless clone of it which only needs to fetch 55 MiB of data and produces a 74MB `.git` folder. Depends on - #6186 **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Depending on the version of Node.js and npm you have available; building the TypeScript patches might not work.
How did you fix it?
nodeandnpm.npm ciwhen a lockfile is present as usingnpm installcauses some TypeScript builds to fail.Checklist