Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(compat): use a treeless TypeScript clone #6193

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Mar 31, 2024

What's the problem this PR addresses?

Building the latest TypeScript patch requires fetching https://github.com/arcanis/typescript, https://github.com/microsoft/typescript, and https://github.com/merceyz/typescript which, according to git, requires fetching 1.87 GiB, 452 MiB, and 42 MiB of data and produces a 2.7GB .git folder.

How did you fix it?

Fork TypeScript to https://github.com/yarnpkg/TypeScript and push the branches required to build all the patches to it and change the script to use a treeless clone of it which only needs to fetch 55 MiB of data and produces a 74MB .git folder.

Depends on

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz force-pushed the merceyz/build/treeless-ts-clone branch from 4bd0334 to c3defd6 Compare April 10, 2024 14:41
@merceyz merceyz marked this pull request as ready for review April 10, 2024 14:42
Copy link
Member

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't know about tree:0

@arcanis arcanis merged commit ded6091 into master Apr 10, 2024
21 of 25 checks passed
@arcanis arcanis deleted the merceyz/build/treeless-ts-clone branch April 10, 2024 19:16
merceyz added a commit that referenced this pull request May 2, 2024
**What's the problem this PR addresses?**

Building the latest TypeScript patch requires fetching
https://github.com/arcanis/typescript,
https://github.com/microsoft/typescript, and
https://github.com/merceyz/typescript which, according to git, requires
fetching 1.87 GiB, 452 MiB, and 42 MiB of data and produces a 2.7GB
`.git` folder.

**How did you fix it?**

Fork TypeScript to https://github.com/yarnpkg/TypeScript and push the
branches required to build all the patches to it and change the script
to use a treeless clone of it which only needs to fetch 55 MiB of data
and produces a 74MB `.git` folder.

Depends on 
- #6186

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants